Dynamically Find Radex/SmartRedis Install Library Dir - #4
Merged
Conversation
Create function to resolve library directory of independent of an operating system's preference for using `lib` or `lib64` convention. Export individual environment variables for Radex and SmartRedis include and library directory. User should still only need to set `RADEX_DIR` and `SMARTREDIS_DIR`, thus leaving the build process unchanged.
ashao
requested changes
Aug 31, 2026
Update the `find_lib` function to work with both MacOS dylibs and static libraries Co-authored-by: Andrew Shao <andrew.shao@hpe.com>
Thanks Microsoft, I hate it... :(
Member
Author
|
Ahhh I keep forgetting about MacOS. Between the lib vs lib64 dirs and |
ashao
approved these changes
Sep 1, 2026
ashao
left a comment
ashao
left a comment
Member
There was a problem hiding this comment.
Lemme dig down deep into our own conventions...LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dynamically finds the library directory for Radex and SmartRedis regardless of an operating systems preference for using
liborlib64. Should leave the build process and necessary to export environment variable unchanged from the perspective of an end user building the plugin.Fixes #3