Skip to content

Set working directory explicitly when running git command#10131

Open
tmvkrpxl0 wants to merge 3 commits intoCreators-of-Create:mc1.21.1/devfrom
coding-1ab:mc1.21.1/dev
Open

Set working directory explicitly when running git command#10131
tmvkrpxl0 wants to merge 3 commits intoCreators-of-Create:mc1.21.1/devfrom
coding-1ab:mc1.21.1/dev

Conversation

@tmvkrpxl0
Copy link
Copy Markdown

@tmvkrpxl0 tmvkrpxl0 commented Apr 6, 2026

I recently tried to include Create using composite build but it tried to run git command from my root project, not inside of Create.
This PR sets working directory when running git command so that it can be included to elsewhere more easily.
Closes #10122

@vercte vercte added the pr flag: simple PR has minimal changes label Apr 6, 2026
@tmvkrpxl0
Copy link
Copy Markdown
Author

tmvkrpxl0 commented Apr 7, 2026

Also should I change usages of runtimeOnly? It doesn't just mean it'd be included when you launch Minecraft in Create source. It also means that dependency is needed at runtime and it's transitive. For example one of runtimeOnly dependency "Architectury" will be downloaded if other project depends on Create without setting transitive = false and it will show up in mods tab when they launch Minecraft.
It's recommended to create new configuration just for adding other mods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr flag: simple PR has minimal changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Suggestion] Make running "git" command in build.gradle support composite build

2 participants