Fix correct shape not being applied to funnels when placed on other funnels#10146
Open
JensenJ wants to merge 1 commit intoCreators-of-Create:mc1.21.1/devfrom
Open
Fix correct shape not being applied to funnels when placed on other funnels#10146JensenJ wants to merge 1 commit intoCreators-of-Create:mc1.21.1/devfrom
JensenJ wants to merge 1 commit intoCreators-of-Create:mc1.21.1/devfrom
Conversation
VoidLeech
added
pr type: fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
This fixes #8945
I'm not terribly sure if this is the right way to fix this, but it's probably the simplest and least invasive. I feel a "cleaner" fix might be better suited within
BeltFunnelBlock.getStateForPlacement()to reduce code duplication as the shape is also calculated there but the direction of the belt funnel is modified here after to make the funnel face the correct direction (which is calculated above) when placed on the side of another funnel. This happens without updating the funnel shape which caused the initial bug.Let me know if you want anything changed or have any questions.
Thanks,
Jensen