Fix brass funnels not extracting items onto mechanical saws in some scenarios

[JensenJ]

Hi there,

This fixes a bug which as far as I can tell has not been reported, where the brass funnel will not extract items onto the saw when using the mechanical saw with funnels in this configuration:

Currently, if you use an andesite funnel it works fine, and if you use a brass funnel with the amount set to 1 it works or if the stack size in the inventory is 1. I think this bug is potentially a byproduct of when the input inventory for the saw was reduced (which may be a bug(???) and thus fixing that would most likely fix this), as I remember it used to stack up everything on the saw then would process items one by one, but this was years ago and on Create Fabric 0.5 when 1.18 was still newish so my memory is a bit murky or that may not have been intended.

The fix I've put in place is based on the behaviour for the normal funnel extraction and in my testing works and looks to be the same logically to my eyes; but as this is dealing with item stacks in such a critical place in combination with the inventory versioning I'd definitely want someone to double check this as I don't really want to inadvertently cause a big duplication glitch or break something somehow.

Let me know if you want anything changed or if you have any questions.

Thanks,
Jensen

[VoidLeech]

Slightly contrived because you'd never do that if setting up the saw and funnel like this, but if the funnel is set to the exactly N mode, then this will only extract 1 item (though ofc only after the inventory has N or more items), ignoring the exactly mode.

Saw having a limited slot size actually dates back all the way to 0.3.2 (very intentional, bulk sawing is behind a config now), I think any "stacking" on the saw would have to be even older as the offsets have been solidly set in stone since before that even.

[JensenJ]

Thanks for looking at this.

Saw having a limited slot size actually dates back all the way to 0.3.2 (very intentional, bulk sawing is behind a config now), I think any "stacking" on the saw would have to be even older as the offsets have been solidly set in stone since before that even.

I just booted up an old modpack which I remember the behaviour I described above happening on and it seems it was an addon or possibly something I modified in Create for my server as I also had the saw recipes cached on the recipe lookup as we used a kubejs script to add all of decorative blocks from chipped to the saw for automation and that caused a lot of lag due to the thousands of added recipes (if recipe caching doesn't exist on the saw nowadays I might do a PR for that also, as in some modpacks it might be a bit laggy). Anyway, that official release version of create fabric standalone has the same behaviour as the current neoforge version in terms of "stacking", so this checks out.

Slightly contrived because you'd never do that if setting up the saw and funnel like this, but if the funnel is set to the exactly N mode, then this will only extract 1 item (though ofc only after the inventory has N or more items), ignoring the exactly mode.

The only "fix" I can think of to this would be making the saw's input slot larger, processing either one at a time or the whole stack depending on the bulk processing config. This would let a funnel extract for example 16 blocks into the saw's inventory at once, assuming we treated the input like a depot, where funnels can only insert a complete stack rather than modify an existing one in terms of item count. But this is almost certainly overcomplicating things (I tend to do that), for quite a niche use case.