Fix culling / occlusion on saw, drill, deployer and portable storage interface#10155
Open
JensenJ wants to merge 1 commit intoCreators-of-Create:mc1.21.1/devfrom
Open
Fix culling / occlusion on saw, drill, deployer and portable storage interface#10155JensenJ wants to merge 1 commit intoCreators-of-Create:mc1.21.1/devfrom
JensenJ wants to merge 1 commit intoCreators-of-Create:mc1.21.1/devfrom
Conversation
VoidLeech
added
pr type: fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
This fixes #6117 and the same issue for the drill, deployer and portable storage interface (this issue does not affect fluid interface as the model is different). Easiest to see by placing snow layers next to each of these blocks as mentioned in that linked issue.
I'm not sure if this is the cleanest way to fix this as it may be a little over the top to disable all occlusion for these blocks just for the tiny bit exposed on some faces, but the only other options I can think of are changing the voxel shape to more accurately reflect the model (which if I remember correctly(?) may incur a tiny extra performance cost for collisions etc), changing the model or cooking up something for occlusion on certain faces. But then again, I would think turning off occlusion on modern hardware for these blocks shouldn't have that much of a noticeable impact.
Thanks