Fix voxelshape collisions of press, mixer and deployer#10163
Open
JensenJ wants to merge 1 commit intoCreators-of-Create:mc1.21.1/devfrom
Open
Fix voxelshape collisions of press, mixer and deployer#10163JensenJ wants to merge 1 commit intoCreators-of-Create:mc1.21.1/devfrom
JensenJ wants to merge 1 commit intoCreators-of-Create:mc1.21.1/devfrom
Conversation
Replaced voxel shape for mechanical press and mixer with a mixin. This mixin also changes the logic for placing things on the side of the deployer so that it is consistent with the press and mixer.
VoidLeech
added
pr type: fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
This fixes #8961 using the suggestion IThundxr made on that issue.
I did this within FaceAttachedHorizontalDirectionalBlock.canAttach instead of canPlace, as I figured it would be best to do this here, for best compatibility (perhaps?), as a mixin into just Button and Lever may leave some other edge case that's been forgotten? I've also added a case in this mixin for the deployer so placing levers/buttons on the side of it works the same as the mixer / deployer to make it consistent, as before you could only place a lever / button on the top face of it where the pole retracts.
Let me know if you want anything changed or have any questions.
Thanks