Skip to content

Fix chromatic compound not gaining light from consuming light sources #10172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
VoidLeech wants to merge 1 commit into
base: mc1.21.1/dev
Choose a base branch
from
Open

Fix chromatic compound not gaining light from consuming light sources #10172

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/main/java/com/simibubi/create/content/legacy/ChromaticCompoundItem.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

import com.simibubi.create.AllDataComponents;

import net.minecraft.core.component.DataComponentMap;

import org.apache.commons.lang3.mutable.MutableBoolean;

import com.simibubi.create.AllItems;
Expand Down Expand Up @@ -45,6 +47,10 @@ public int getLight(ItemStack stack) {
return stack.getOrDefault(AllDataComponents.CHROMATIC_COMPOUND_COLLECTING_LIGHT, 0);
}

public int getLight(DataComponentMap components) {
return components.getOrDefault(AllDataComponents.CHROMATIC_COMPOUND_COLLECTING_LIGHT, 0);
}

@Override
public boolean isBarVisible(ItemStack stack) {
return getLight(stack) > 0;
Expand Down Expand Up @@ -218,8 +224,9 @@ public boolean checkLight(ItemStack stack, ItemEntity entity, Level world, ItemS
.getBlockPos()))
return false;

DataComponentMap components = itemStack.getComponents();
ItemStack newStack = stack.split(1);
newStack.set(AllDataComponents.CHROMATIC_COMPOUND_COLLECTING_LIGHT, getLight(itemStack) + 1);
newStack.set(AllDataComponents.CHROMATIC_COMPOUND_COLLECTING_LIGHT, getLight(components) + 1);
ItemEntity newEntity = new ItemEntity(world, entity.getX(), entity.getY(), entity.getZ(), newStack);
newEntity.setDeltaMovement(entity.getDeltaMovement());
newEntity.setDefaultPickUpDelay();
Expand Down
Loading