Fix Unpacking order & Vanilla Crafter#10188
Open
LIUKRAST wants to merge 2 commits intoCreators-of-Create:mc1.21.1/devfrom
Open
Fix Unpacking order & Vanilla Crafter#10188LIUKRAST wants to merge 2 commits intoCreators-of-Create:mc1.21.1/devfrom
LIUKRAST wants to merge 2 commits intoCreators-of-Create:mc1.21.1/devfrom
Conversation
VoidLeech
added
the
pr type: feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! My pull request includes two fixes/features
Unpacking Order is not respected
This is a simple issue: when ordering items from a packager linked, the order is only respected if the package passes through a re-packager. This is solved by respecting the orderedStacks context when unboxing packages
Steps to reproduce the issue:
Order is now not respected and it will use 2 cobblestone & 2 quartz
The fix obviously doesn't use orderedStacks itself, but checks that the contents are valid before unpacking in the correct order
Unpacking to vanilla crafter
Pretty self explanatory. If a packager is connected to a Crafter (vanilla one), it now respects the orderedCrafts data to craft items correctly, just like mechanical crafters