Fix inverted angular velocity correction in the flux effective collection area - #978
Draft
Cybis320 wants to merge 2 commits into
Draft
Fix inverted angular velocity correction in the flux effective collection area#978Cybis320 wants to merge 2 commits into
Cybis320 wants to merge 2 commits into
Conversation
…numerator-denominator consistency
Contributor
Author
|
The FWHM convention fix referenced above is #977. For typical far-radiant pointing the two errors partially cancel, so the flux impact should be evaluated with both PRs together. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The per-block angular-velocity correction in the flux effective collection area is inverted:
Meteors in blocks where they move slower than at the FOV middle are detectable to a deeper limiting magnitude, so those blocks see more of the population and their effective area must be boosted — the same convention as the range correction directly above it, where the disadvantaged (farther) block gets a correction < 1 (
c_range = (100/r)², eq. 41 of Vida et al. 2022). Deriving the angular-velocity term under that same convention from the population scalingN(>L) ∝ L^(1−s)gives c_θ = θ₀/θ_block — the reciprocal of both the code and eq. 43 as printed in the paper.The one-line proof
No external physics is needed to see the inconsistency — it is internal to
computeFluxCorrectionsOnBins. About 55 lines above the block loop, the bin-level meteor limiting magnitude treats angular velocity strictly as a detection loss:The clamp explicitly asserts that higher angular velocity can only ever hurt detectability. Yet the per-block weight
ang_vel/ang_vel_midrewarded blocks with higher angular velocity with more effective collection area. The same function penalizes angular velocity in the reference LM and rewarded it in the area weighting; one of the two must be wrong, and the clamp's direction is the physically undisputed one.Two further pieces of internal evidence in the paper indicate the printed equation (which transcribes the code) is the error:
Provenance: the direction dates to
70c10361(Jan 2021, first implementation);22962d91(Mar 2022, "fixed angular velocity correction") changed only the reference point; the paper documented the code as built.Measured impact (archived GMN data, US005E)
Rerunning archived nights with only the ratio flipped, the per-bin effective area ratio (corrected/current) tracks the radiant distance from the FOV center:
So beyond the net bias, the inversion makes cameras disagree systematically by up to ~2.5× depending on where each points relative to the radiant — inflating network scatter.
Changes (
Utils/Flux.py)ang_vel_mid/ang_vel, with the factor-of-10 cap described in the paper applied inline (min(max(·, 0.1), 10)), which also guards the θ→0 singularity.max(·, 0.1)) that the paper describes but was commented out.ang_vel_minare now excluded from the count, mirroring the exclusion of slow blocks from the effective collection area (blocks below 20° elevation already have a matching meteor cut; the angular-velocity cut did not). This is a no-op on the tested nights but activates for low-pointing/long-range geometries and slow showers.Validation
ang_vel_minblock exclusion already limits the boost to θ₀/θ_min).Note for the maintainers
If this derivation is confirmed, eq. 43 of the flux methodology paper (MNRAS 515, 2322) carries the same inversion, which may warrant an erratum. Because this and the FWHM fix shift fluxes in opposite directions for typical far-radiant pointing (partially canceling), they should be evaluated together.
🤖 Generated with Claude Code
https://claude.ai/code/session_01B6s6Z27vWeL1Ume1t9AAfz