CameraControl: add Isp commands (isp_ctl/hisp_ctl pass-through) - #984
Draft
Cybis320 wants to merge 1 commit into
Draft
CameraControl: add Isp commands (isp_ctl/hisp_ctl pass-through)#984Cybis320 wants to merge 1 commit into
Cybis320 wants to merge 1 commit into
Conversation
Adds the ispControl() helper and four dvripCall handlers -- IspQuery, IspManual, IspAuto, and a generic Isp pass-through -- that talk to the isp_ctl/hisp_ctl TCP daemon on the camera's :9600 port. This reaches manual ISP exposure/gain and pipeline control that DVRIP cannot (e.g. `Isp wb unity`, `Isp gain 4096`, `Isp ae`, `Isp drc off`, `Isp status`). The daemon takes one text command per TCP connection, returns its response, then closes; ispControl() forwards the command verbatim and logs the reply. Commands target cam.ip, so they work in config mode today and pair naturally with the standalone --ip flag (#983) for bench/ad-hoc cameras without a config. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds camera-side ISP control to
Utils/CameraControl.pyvia theisp_ctl/hisp_ctlTCP daemon on port 9600:ispControl(ip, cmd_line)— sends one text command per TCP connection and returns the reply.IspQuery/IspManual/IspAuto— fixed-string convenience commands.Isp <anything>— generic pass-through, e.g.Isp wb unity,Isp gain 4096,Isp ae,Isp status,Isp drc off.cmd_list.Why
DVRIP cannot reach true manual ISP exposure/gain or individual pipeline stages (gamma, WB, DRC, NR, DPC, encoder bitrate/QP). The on-camera
isp_ctl/hisp_ctldaemon exposes those; this gives CameraControl a first-class way to drive it.Notes
cam.ip, so they work in config mode today; they pair with the standalone--ipflag (CameraControl: add --ip for standalone control without an RMS config #983) for config-free bench use.isp_ctl/hisp_ctldaemon on the camera (firmware-side, out of scope for this PR). Without it,ispControllogs a connection error and returnsNone.Draft — before un-drafting
opthelp/ argparse help.🤖 Generated with Claude Code