Preview Of Parametric Curve Mode#1017
Draft
mmadesignerunknown wants to merge 1 commit intoCyberTimon:mainfrom
Draft
Preview Of Parametric Curve Mode#1017mmadesignerunknown wants to merge 1 commit intoCyberTimon:mainfrom
mmadesignerunknown wants to merge 1 commit intoCyberTimon:mainfrom
Conversation
1 task
Owner
|
@mmadesignerunknown Looks good, I like the UI; I'm only worried if a +600 lines code change is really needed? |
Contributor
Author
You are right to be concerned, but the thing is that the code is AI-generated, and almost 50+ lines are just AI-comments, i might also be able to clean it up a bit more but I first wanted to get the frontend math and logic finalised before moving to next steps. Hope it helps, Regards, |
Contributor
Author
|
Well then, I will start working on the clean-up and backend tomorrow :) |
Owner
|
Thanks a lot! Looking forward to it 💯 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added Parametric Curve modes for RGB Channels.
Type of Change
Changes Made
Screenshots/Videos
I couldn't capture/record it. But if you want to test the changes, download these files and replace them with the Curves.tsx and adjustments.tsx respectively.
Curves.tsx
adjustments.tsx
Testing
Test Configuration:
Checklist
They are added for now because it's just a preview, I will remove them once this gets finalized
Additional Notes
Only the frontend has been implemented right now, I will implement the backend once the frontend gets finalized.
AI Disclaimer:
Please state the involvement of AI in this PR:
Inspiration: