Skip to content

Auto adjust image improvements: Overexposure reduction and removes UI thread block#954

Open
moschmdt wants to merge 1 commit intoCyberTimon:mainfrom
moschmdt:fix-auto-adjust
Open

Auto adjust image improvements: Overexposure reduction and removes UI thread block#954
moschmdt wants to merge 1 commit intoCyberTimon:mainfrom
moschmdt:fix-auto-adjust

Conversation

@moschmdt
Copy link
Copy Markdown

@moschmdt moschmdt commented Apr 1, 2026

Description

The issue is already described extensively in #568.
Additionally, the auto adjust for multiple images has been put in a thread not blocking the UI and includes a progress indicator now.

Type of Change

  • Bug fix
  • Code refactoring
  • UI/UX improvement

Changes Made

  • Add blacks/whites to the AutoAdjust structure to counter high exposure
  • Reduce the scaling variables
  • Name the scaling variables, so in the future something like custom configs could be possible for auto adjust.

Screenshots/Videos

Screenshot 2026-04-01 at 18 32 00 Screenshot 2026-04-01 at 18 31 58 Screenshot 2026-04-01 at 18 31 28

Previous behavior see #568.

Testing

  • I have tested these changes locally and confirmed that they work as expected without issues

Test Configuration:

  • OS: macOS Tahoe
  • Hardware: M1 Pro

Checklist

  • My code follows the project's code style
  • I haven't added unnecessary AI-generated code comments
  • My changes generate no new warnings or errors

Additional Notes

AI Disclaimer:

Please state the involvement of AI in this PR:

  • This PR is entirely AI-generated
  • This PR is AI-generated but guided by a human
  • This PR was handwritten with AI assistance (spell check, logic suggestions, error resolving)
  • This PR contains only blood, sweat, and coffee (AI-free)

@moschmdt moschmdt requested a review from CyberTimon as a code owner April 1, 2026 16:42
@CyberTimon
Copy link
Copy Markdown
Owner

Thanks for your PR. Can you please just commit the backend changes, as the UI side will follow a different design?

@moschmdt
Copy link
Copy Markdown
Author

moschmdt commented Apr 7, 2026

Done! Thank you for creating this project!

@CyberTimon
Copy link
Copy Markdown
Owner

@moschmdt Thanks so much for the quick change! Very nice. Can you please lastly remove the AI code comments or keep them to a very minimum (just the ones absolutely needed) and fix the merge conflict? In the last version, I've already moved the processing to a seperate thread, so probably just the improved auto adjust algorithm is needed. Thanks!

@moschmdt
Copy link
Copy Markdown
Author

moschmdt commented Apr 8, 2026

I will have a look at it!

What do you think about exposing the variables for the auto-adjust algorithm via settings to the user to fit the user’s expectation more precisely/ make experimentation easier without recompile?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants