Auto adjust image improvements: Overexposure reduction and removes UI thread block#954
Open
moschmdt wants to merge 1 commit intoCyberTimon:mainfrom
Open
Auto adjust image improvements: Overexposure reduction and removes UI thread block#954moschmdt wants to merge 1 commit intoCyberTimon:mainfrom
moschmdt wants to merge 1 commit intoCyberTimon:mainfrom
Conversation
Owner
|
Thanks for your PR. Can you please just commit the backend changes, as the UI side will follow a different design? |
0cd162a to
3d5654d
Compare
Author
|
Done! Thank you for creating this project! |
Owner
|
@moschmdt Thanks so much for the quick change! Very nice. Can you please lastly remove the AI code comments or keep them to a very minimum (just the ones absolutely needed) and fix the merge conflict? In the last version, I've already moved the processing to a seperate thread, so probably just the improved auto adjust algorithm is needed. Thanks! |
Author
|
I will have a look at it! What do you think about exposing the variables for the auto-adjust algorithm via settings to the user to fit the user’s expectation more precisely/ make experimentation easier without recompile? |
3d5654d to
47fc217
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The issue is already described extensively in #568.
Additionally, the auto adjust for multiple images has been put in a thread not blocking the UI and includes a progress indicator now.
Type of Change
Changes Made
Screenshots/Videos
Previous behavior see #568.
Testing
Test Configuration:
Checklist
Additional Notes
AI Disclaimer:
Please state the involvement of AI in this PR: