Encrypted db progress - #1
Closed
vikalp-mightybyte wants to merge 9 commits into
Closed
Conversation
added 9 commits
July 27, 2023 14:07
Changes: - add a flag if using encrypted DB - install openssl if using encrypted db
- add pathes to cipher amalgamation based on the flags. - add openSSL lib
vikalp-mightybyte
added a commit
that referenced
this pull request
Aug 5, 2026
ci.yml declared no permissions at all, so its four jobs ran with the default token scope (alerts #1-#4, actions/missing-workflow-permissions). None of them write to the repository, so declare contents: read at the top level, matching what security.yml and codeql.yml already do. Alert #5 (js/insecure-randomness) flagged Math.random() reaching the SQLiteAdapter constructor. It is a false positive in substance: every source is a test file excluded from the published build, and the value becomes a database filename, passed to nativeWatermelonCreateAdapter as the path argument and never mixed with the password. CodeQL treats the constructor as a security context only because it also accepts a `passphrase`. Rather than dismiss it, use counters — these names only ever need to be unique, and a counter cannot collide at all, so this is if anything more correct than random. Jest spreads test files across worker processes, so the file-backed cases combine the counter with process.pid; a counter alone would not be unique across workers. process.pid is undefined under React Native, which runs single-process, so it falls back to a constant. Left alone: Math.random() for record ids in commonTests, which does not reach an adapter constructor. Verified jest, eslint, tslint, tsc and flow clean on Node 22 and 24.18.0, both with parallel workers and in the forced single-process ordering. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an exact copy of PR Nozbe#1635