Skip to content

Improved Equals performance #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rsstudios wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improved Equals performance #111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/Ulid.Unity/Assets/Scripts/Ulid/Ulid.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -582,7 +582,10 @@ private static bool EqualsCore(in Ulid left, in Ulid right)
ref var rB = ref Unsafe.As<Ulid, long>(ref Unsafe.AsRef(in right));

// Compare each element
return rA == rB && Unsafe.Add(ref rA, 1) == Unsafe.Add(ref rB, 1);
var xorA = rA ^ rB;
var xorB = Unsafe.Add(ref rA, 1) ^ Unsafe.Add(ref rB, 1);

return (xorA | xorB) == 0;
}

public bool Equals(Ulid other) => EqualsCore(this, other);
Expand Down
5 changes: 4 additions & 1 deletion src/Ulid/Ulid.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -582,7 +582,10 @@ private static bool EqualsCore(in Ulid left, in Ulid right)
ref var rB = ref Unsafe.As<Ulid, long>(ref Unsafe.AsRef(in right));

// Compare each element
return rA == rB && Unsafe.Add(ref rA, 1) == Unsafe.Add(ref rB, 1);
var xorA = rA ^ rB;
var xorB = Unsafe.Add(ref rA, 1) ^ Unsafe.Add(ref rB, 1);

return (xorA | xorB) == 0;
}

public bool Equals(Ulid other) => EqualsCore(this, other);
Expand Down