Add IPv6 (dual-stack) support for DICOM SCP connections in dcmnet module - #128
Closed
SobhitaMercy wants to merge 1 commit into
Closed
Add IPv6 (dual-stack) support for DICOM SCP connections in dcmnet module#128SobhitaMercy wants to merge 1 commit into
SobhitaMercy wants to merge 1 commit into
Conversation
This change adds IPv6 and dual-stack support to the DICOM network layer (dcmnet) for SCP (server/acceptor) roles. Prior to this patch, DCMTK’s initializeNetworkTCP() and related logic in dul.cc created and bound sockets using only the IPv4 family (AF_INET). As a result, SCP applications (e.g., storescp, movescu, dcmrecv, custom SCPs) could not accept incoming IPv6 connections even though the SCU side already supported IPv6. This patch enables SCPs to accept both IPv4 and IPv6 associations transparently.
Member
|
Thank you very much for your contribution! I have somewhat re-worked the implementation to make the protocol family selectable and today committed the implementation as commit #4215154c9 to our "testing" branch. It should appear in the public repository in a couple of days. |
michaelonken
pushed a commit
that referenced
this pull request
Nov 4, 2025
Added support for explicitly selecting the IP protocol version (including IPv6 and a dual-stack IPv4/v6 mode) to all DCMTK "server" applications that accept incoming DICOM associations. Thanks to Sobhita Mercy <sobhitamercy@gmail.com> for this contribution. This closes GitHub pull request #128.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds IPv6 and dual-stack support to the DICOM network layer (dcmnet) for SCP (server/acceptor) roles. Prior to this patch, DCMTK’s initializeNetworkTCP() and related logic in dul.cc created and bound sockets using only the IPv4 family (AF_INET). As a result, SCP applications (e.g., storescp, movescu, dcmrecv, custom SCPs) could not accept incoming IPv6 connections even though the SCU side already supported IPv6.
This patch enables SCPs to accept both IPv4 and IPv6 associations transparently.