Fix double-delete in DcmJSONReader::clear() - #131
Closed
Oss-Auditor wants to merge 1 commit into
Closed
Conversation
Set jsonDataset_ and tokenArray_ to NULL after deletion to prevent double-delete when the object is reused (e.g., calling readAndConvertJSONFile() multiple times). The reserveTokens() method deletes tokenArray_ without checking if it's already freed, causing crashes on second use.
Member
|
I think the fix works (just tried it). @eichelberg: maybe one can call clear() also earlier in (e.g. just in the beginning of readAndConvertJSONFile()) in order to make the code easier to understand. |
Member
|
Thank you. I just merged the PR (plus Michael's suggestion) into our testing branch. It will appear in the public repository in a few days. |
michaelonken
pushed a commit
that referenced
this pull request
Nov 4, 2025
DcmJSONReader::clear() now sets jsonDataset_ and tokenArray_ to NULL after deletion to prevent double-delete when the object is reused. Thanks to GitHub user "Oss-Auditor" for the pull request. This closes GitHub PR #131.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set jsonDataset_ and tokenArray_ to NULL after deletion to prevent double-delete when the object is reused (e.g., calling readAndConvertJSONFile() multiple times).
The reserveTokens() method deletes tokenArray_ without checking if it's already freed, causing crashes on second use.