MAJ des boutons de copy d'URL #1461
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,73 @@ | ||
| <script lang="ts" setup> | ||
| import { onMounted, ref, useTemplateRef } from "vue"; | ||
| import { RouteLocationRaw } from "vue-router"; | ||
| import router from "../../router"; | ||
|
|
||
| const props = withDefaults(defineProps<{ | ||
| icon: string; | ||
| label?: string; | ||
| successLabel?: string; | ||
| hiddenLabelSuffix?: string; | ||
| contentToCopy: string | RouteLocationRaw; | ||
| isWithinBtnGroup?: boolean; | ||
| }>(), { | ||
| label: "Copier le lien de partage", | ||
| successLabel: "Lien copié" | ||
| }); | ||
|
|
||
| const showSuccess = ref(false); | ||
|
|
||
| function copyContentToClipboard() { | ||
| if (showSuccess.value) return; | ||
|
|
||
| const content = typeof props.contentToCopy === "string" | ||
| ? props.contentToCopy | ||
| : window.location.origin + router.resolve(props.contentToCopy).fullPath; | ||
|
|
||
| navigator.clipboard.writeText(content).then(() => { | ||
| showSuccess.value = true; | ||
| }); | ||
|
|
||
| setTimeout(() => { | ||
| showSuccess.value = false; | ||
| }, 3500); | ||
| } | ||
|
|
||
| const initialButtonWidth = ref<string>(); | ||
| const copyButtonRef = useTemplateRef("copyButtonRef"); | ||
|
|
||
| onMounted(() => { | ||
| // FIXME: `setTimeout()` used to force computing element's width after prop is assigned | ||
|
Collaborator
Author
There was a problem hiding this comment. Fonctionne pas à tous les coups. Je suis preneur de solutions pour les reviewers ! |
||
| setTimeout(() => { | ||
| initialButtonWidth.value = `${copyButtonRef.value?.offsetWidth}px`; | ||
| }, 500); | ||
| }); | ||
| </script> | ||
|
|
||
| <template> | ||
| <button | ||
| ref="copyButtonRef" | ||
| type="button" | ||
| :class="[`fr-btn fr-btn--secondary fr-btn--icon-left ${showSuccess ? 'fr-icon-check-line copy-button--success' : icon} copy-button`, { | ||
| 'copy-button--within-btn-group fr-mb-0': isWithinBtnGroup | ||
| }]" | ||
| @click="copyContentToClipboard" | ||
| > | ||
| {{ showSuccess ? successLabel : label }} | ||
| <span v-if="hiddenLabelSuffix" class="fr-sr-only">{{ hiddenLabelSuffix }}</span> | ||
| </button> | ||
| </template> | ||
|
|
||
| <style scoped> | ||
| .copy-button { | ||
| &:not(.copy-button--within-btn-group) { | ||
| width: v-bind(initialButtonWidth) !important; | ||
|
Collaborator
There was a problem hiding this comment. Super le Attention ça casse le côté responsive sur petits écrans, côté rapport ("within btn group"). Rajouter ici : max-width: 100%;Et sur flex-wrap: wrap;
max-width: 100%;
Collaborator
Author
There was a problem hiding this comment. Bien vu ! D'ailleurs, j'ai l'impression que seul le |
||
| justify-content: center !important; | ||
| } | ||
| } | ||
|
|
||
| .copy-button--success { | ||
| color: var(--text-default-success) !important; | ||
| box-shadow: inset 0 0 0 1px var(--text-default-success) !important; | ||
| } | ||
| </style> | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Attention le comportement est étrange si on clic alors que le message de succès est déjà affiché et que le délai (
setTimeout) est en cours.Après la sélection du bouton "Copier le lien de partage", changer le
<button>par une<div>? Ainsi il ne sera plus possible de cliquer dessus ! Attention à la restitution aux aides techniques.Aussi, pour aller jusqu’au bout, on peut vérifier l’id retourné par le
setTimeout: ne pas relancer desetTimeouttant qu’un délai est en cours.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dans la méthode, j'ai rajouté ça pour ne rien faire si on montre déjà le succès. Et du coup ça relance pas un nouveau
setTimeout().