Fait le ménage dans les différentes méthodes findAudit***#1476
Open
Fait le ménage dans les différentes méthodes findAudit***#1476
Conversation
bellangerq
approved these changes
Apr 22, 2026
| } | ||
| } | ||
| /** Find and return an audit in the format that the API would return */ | ||
| findAuditWithEditUniqueId(uniqueId: string): Promise<AuditDto> { |
Collaborator
There was a problem hiding this comment.
Est-ce qu'on l'appelerait pas simplement findAudit() ? Car la suite du nom suppose justement qu'on puisse le chercher avec autre chose que le editUniqueId, comme avant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Il existait plusieurs méthodes pour récupérer des audits avec des noms légérements différents, et dont les différences étaient vagues et/ou pas cohérentes.
findAuditWithEditUniqueIdgetAuditWithEditUniqueIdgetAuditWithConsultUniqueIdCette PR fait le ménage dans tout ça et ne laisse qu’une seule méthode
findAuditWithEditUniqueId()qui retourne une entitéAuditavec ses relations (objets nestés) remplies de sorte à pouvoir être retournée directement par l’API (typeAuditDto)TODO (dans une autre PR): refactor la vérification de l’existence d’un audit