Skip to content

No ticket: Update thor to address vulnerability#847

Merged
patsier-cms merged 1 commit into
mainfrom
fix/thor-dep-vuln
Jul 23, 2025
Merged

No ticket: Update thor to address vulnerability#847
patsier-cms merged 1 commit into
mainfrom
fix/thor-dep-vuln

Conversation

@patsier-cms

Copy link
Copy Markdown
Contributor

Ticket

Fixes vulnerability that's currently failing the build

Changes

Context for reviewers

Wanted to open a quick fix to hopefully get this addressed with less review than automated PRs currently

Acceptance testing

  • No acceptance testing needed
    • This change will not affect the user experience (bugfix, dependency updates, etc.)
  • Acceptance testing prior to merge
    • This change can be verified visually via screenshots attached below or by sending a link to a local development environment to the acceptance tester
    • Acceptance testing should be done by design for visual changes, product for behavior/logic changes, or both for changes that impact both.
  • Acceptance testing after merge
    • This change is hard to test locally, so we'll test it in the demo environment (deployed automatically after merge.)
    • Make sure to notify the team once this PR is merged so we don't inadvertently deploy the unaccepted change to production. (e.g. :alert: Deploy block! @ffs-eng I just merged PR [#123] and will be doing acceptance testing in demo - please don't deploy until I'm finished!)

Comment thread app/Gemfile

@millerti millerti left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if thor isn't necessary, I did a quick runthrough on sandbox and didn't see any issues. LGTM

@patsier-cms patsier-cms merged commit b701c08 into main Jul 23, 2025
16 checks passed
@patsier-cms patsier-cms deleted the fix/thor-dep-vuln branch July 23, 2025 17:19
daphnegold pushed a commit that referenced this pull request Jul 24, 2025
Pilot is only ended if production env

Testing is good

Revert "Testing is good"

This reverts commit 36542d5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants