Skip to content

fix #5488: add ARIA labeling to hide edit menu from screen readers wh…#5514

Open
guillermo-escire wants to merge 1 commit intoDSpace:mainfrom
guillermo-escire:feature/5488
Open

fix #5488: add ARIA labeling to hide edit menu from screen readers wh…#5514
guillermo-escire wants to merge 1 commit intoDSpace:mainfrom
guillermo-escire:feature/5488

Conversation

@guillermo-escire
Copy link
Copy Markdown
Contributor

References

Fixes #5488

Description

Adds dynamic ARIA labeling to the DSO edit menu so that when a user has no edit permissions, the menu is hidden from screen readers and the role="menubar" attribute is removed, preventing the broken ARIA menu error detected by the WAVE accessibility tool.

Instructions for Reviewers

List of changes in this PR:

  • dso-edit-menu.component.html: role="menubar" is now dynamic — only applied when the menu has visible subsections. Added aria-hidden="true" when no subsections are visible.
  • dso-edit-menu.component.ts: Added menuVisibleWithSections$ observable that checks real subsections with permissions via getSubSectionsByParentID.
  • dso-edit-menu.component.spec.ts: Added tests to verify DOM behavior for both cases.

How to test:

  1. Install the WAVE browser extension
  2. Navigate to any community or item page without being logged in
  3. Run WAVE — the Broken ARIA menu error should no longer appear
  4. Log in as an admin and navigate to the same pages — the edit menu (three dots) should still appear and work correctly

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@lgeggleston lgeggleston added bug accessibility 1 APPROVAL pull request only requires a single approval to merge testathon Reported by a tester during Community Testathon labels Apr 21, 2026
@lgeggleston lgeggleston moved this to 🙋 Needs Reviewers Assigned in DSpace 10.0 Release Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge accessibility bug testathon Reported by a tester during Community Testathon

Projects

Status: 🙋 Needs Reviewers Assigned

Development

Successfully merging this pull request may close these issues.

ARIA menu error on community and item pages

2 participants