Skip to content

Build LZMA as an object, disable LZMA known warning, implement USE_WERROR and use it in Azure CI#97

Open
illwieckz wants to merge 5 commits into
masterfrom
illwieckz/lzma
Open

Build LZMA as an object, disable LZMA known warning, implement USE_WERROR and use it in Azure CI#97
illwieckz wants to merge 5 commits into
masterfrom
illwieckz/lzma

Conversation

@illwieckz
Copy link
Copy Markdown
Member

@illwieckz illwieckz commented May 20, 2026

Build LZMA as an object, disable LZMA known warning, implement USE_WERROR and use it in Azure CI.

The warning from vendored LZMA can be re-enabled with IGNORE_VENDORED_WARNING=OFF.

Include changes from:

Because it reuses helpers from it.

@illwieckz illwieckz changed the title Split LZMA compilation, disable LZMA known warning, enable -Werror in Azure CI Build LZMA as an object, disable LZMA known warning, enable -Werror in Azure CI May 20, 2026
@illwieckz illwieckz force-pushed the illwieckz/lzma branch 2 times, most recently from 99a44ce to 5aa1dca Compare May 20, 2026 02:39
@illwieckz illwieckz changed the title Build LZMA as an object, disable LZMA known warning, enable -Werror in Azure CI Build LZMA as an object, disable LZMA known warning, implement USE_WERROR and use it in Azure CI May 20, 2026
@illwieckz
Copy link
Copy Markdown
Member Author

MSVC has its own share of warnings, this PR only focuses on MinGW/GCC/Clang ones, so USE_WERROR isn't enabled in Appveyor CI.

@slipher
Copy link
Copy Markdown
Member

slipher commented May 20, 2026

What's the objective of making LZMA a separate library?

stringop-whatever are shit warnings that produce mostly false positives in Unvanquished too. Just turn them off everywhere.

@illwieckz
Copy link
Copy Markdown
Member Author

illwieckz commented May 20, 2026

What's the objective of making LZMA a separate library?

Actually it is already a separate library. I already moved the files to a separate folder in #76, this pushes things further.

The motivation was to be able to add specific compiler options, but it's good even without that anyway. That was just the motivation for doing it now.

stringop-whatever are shit warnings that produce mostly false positives in Unvanquished too. Just turn them off everywhere.

Uhh, ok. That can be done too.

What do you think about the general idea of using -Werror in CI? This can bite in the back when updating compilers, or updating vendored libraries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants