Skip to content

Support HarmonyOS#652

Open
KiritoFD wants to merge 23 commits intoDanXi-Dev:mainfrom
KiritoFD:harmony
Open

Support HarmonyOS#652
KiritoFD wants to merge 23 commits intoDanXi-Dev:mainfrom
KiritoFD:harmony

Conversation

@KiritoFD
Copy link
Copy Markdown

No description provided.

@KiritoFD
Copy link
Copy Markdown
Author

this has no conflict with the main branch , but if you insist , I will start a new repo.

@w568w
Copy link
Copy Markdown
Member

w568w commented Feb 25, 2026

Some general suggestions:

  1. You may want to exclude cached / temporary files from your repository with .gitignore first, e.g., harmony/ohos/.hvigor, ohos/{.hvigor.bak,cache,reports}, third_party/_local, bm_dump_latest.txt, etc. Then use git rm --cached to untrack them and push. You were tracking and committing all of them to the remote repository, which is a bad practice.
  2. This PR renames the Android / iOS package name (e.g., in android/app/src/main/AndroidManifest.xml), which is a breaking change. Can you explain the reason?
  3. There are many mixed changes in lib/. Maybe we need to inspect their necessity one by one before deciding whether we want to merge it.

@KiritoFD KiritoFD marked this pull request as draft February 25, 2026 16:01
@w568w w568w changed the title Harmony Support HarmonyOS Feb 26, 2026
@w568w w568w added enhancement New feature or request internal The request is from our team and not widely applicable. Complexity: High Difficult to trace the root cause, or requiring a thorough understanding of the entire project labels Feb 26, 2026
@KiritoFD KiritoFD marked this pull request as ready for review April 26, 2026 13:32
@KiritoFD
Copy link
Copy Markdown
Author

built with the OpenHarmony Flutter 3.35 SDK. the adaptation is intentionally non-invasive and build-scoped; added lines are mostly requirements in .vendor

@w568w
Copy link
Copy Markdown
Member

w568w commented May 10, 2026

If you feel ready to get it reviewed, please let me know!

@KiritoFD
Copy link
Copy Markdown
Author

If you feel ready to get it reviewed, please let me know!

Yes, it's ready for review.
most of the added files are dependency files (like the .vendor directory) included to keep the HarmonyOS build stable. The core logic remains completely untouched. I can strip these dependencies out if you prefer a cleaner PR diff, though it might complicate the build setup .

@w568w w568w self-requested a review May 10, 2026 13:11
Copy link
Copy Markdown
Member

@w568w w568w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some preliminary findings below.

Also, could you please explain why it requires 6 directories to support HarmonyOS?

  • Harmony/ and ohos/ look the same thing to me.
  • .vendor/ and .vendor_ohos/: what are their purposes? To re-package some platform-specific packages?
  • .ohos/: what's the difference from ohos/?

Comment thread official_doc.txt
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be better removed, or moved to https://github.com/DanXi-Dev/docs

Comment thread build_ohos.ps1
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to #676, you may want to move these *.ps1 to packaging/.

Comment thread docs/build-workflow.md
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All docs (especially AI-generated ones) should be excluded from the repo for now. You may want to upload them to https://github.com/DanXi-Dev/docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complexity: High Difficult to trace the root cause, or requiring a thorough understanding of the entire project enhancement New feature or request internal The request is from our team and not widely applicable.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants