Skip to content

Avoid logging stack trace during expected remote-config exception #11328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gh-worker-dd-mergequeue-cf854d merged 5 commits into from
Jun 9, 2026
+9 −1
Merged

Avoid logging stack trace during expected remote-config exception #11328

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cd76457
Avoid logging stack trace during expected remote-config exception
sarahchen6 May 8, 2026
0e6bdee
Use e.getMessage for ClosedSelectorExceptions specifically
sarahchen6 May 8, 2026
fb80a06
Merge branch 'master' into sarahchen6/apms-19495
sarahchen6 Jun 8, 2026
7b52f0b
Clarify expectation in comment
sarahchen6 Jun 8, 2026
44678db
Merge branch 'master' into sarahchen6/apms-19495
sarahchen6 Jun 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...fig/remote-config-core/src/main/java/datadog/remoteconfig/DefaultConfigurationPoller.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,7 +378,7 @@ private void handleAgentResponse(ResponseBody body) {
fleetResponse = maybeFleetResp.get();
} catch (Exception e) {
// no error can be reported, as we don't have the data client.state.targets_version avail
ratelimitedLogger.warn("Error parsing remote config response", e);
ratelimitedLogger.warn("Error parsing remote config response: {}", e.toString());
Comment thread
sarahchen6 marked this conversation as resolved.
Outdated

@dougqh dougqh May 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e.getMessage() might be better.

I'm also not sure if we still want to pass the exception somehow for exception metric reporting purposes. I've always thought we should have a helper that handles this better.

Something like warnExpected / warnQuielty?. Although, I guess use of a rateLimitedLogger is itself an indication that an exception is expected here.

@dougqh dougqh May 8, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also worth thinking about whether, all Exceptions are expecting or only a subset.

@sarahchen6 sarahchen6 May 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. It looks like ClosedSelectorExceptions are what's expected when selectors are closed mid-poll, so I'll update those exceptions specifically to use e.getMessage().

@sarahchen6 sarahchen6 May 8, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 0e6bdee!

return;
}

Expand Down
Loading