Skip to content

Improve http codec extractor tests#11640

Open
PerfectSlayer wants to merge 1 commit into
masterfrom
bbujon/groovy-to-java
Open

Improve http codec extractor tests#11640
PerfectSlayer wants to merge 1 commit into
masterfrom
bbujon/groovy-to-java

Conversation

@PerfectSlayer

Copy link
Copy Markdown
Contributor

Extract the ContextInterpreter tests related to AppSec to remove duplication. Handle extractor initialization in a new parent test class Deduplicate constants and values into the new parent test class

What Does This Do

This PR improves the HttpCodec extractor tests that were recently moved to JUnit and cleaned up ( #11576, #11581, #11606).
It goes a step further by:

  • Extracting the ContextInterpreter tests related to AppSec to remove duplication,
  • Handling extractor initialization in a new parent test class
  • Deduplicating constants and values into the new parent test class

Motivation

Additional Notes

This should only be a refactor, no behavior change.
The only change is that AppSec is now tests with all the propagation styles where B3 and X-Ray were previously missing.

Contributor Checklist

  • Format the title according to the contribution guidelines
  • Assign the type: and (comp: or inst:) labels in addition to any other useful labels
  • Avoid using close, fix, or any linking keywords when referencing an issue
    Use solves instead, and assign the PR milestone to the issue
  • Update the CODEOWNERS file on source file addition, migration, or deletion
  • Update public documentation with any new configuration flags or behaviors
  • Add your completed PR to the merge queue by commenting /merge. You can also:
    • Customize the commit message associated with the merge with /merge --commit-message "..."
    • Remove your PR from the merge queue with /merge -c
    • Skip all merge queue checks with /merge -f --reason "reason"; please use this judiciously, as some checks do not run at the PR-level (note: the PR still needs to be mergeable, this will only skip the pre-merge build)
    • Get more information in this doc

Jira ticket: [PROJ-IDENT]

Extract the ContextInterpreter tests related to AppSec to remove duplication.
Handle extractor initialization in a new parent test class
Deduplicate constants and values into the new parent test class
@PerfectSlayer PerfectSlayer requested a review from a team as a code owner June 13, 2026 06:03
@PerfectSlayer PerfectSlayer added the tag: no release notes Changes to exclude from release notes label Jun 13, 2026
@PerfectSlayer PerfectSlayer requested a review from mhlidd June 13, 2026 06:04
@PerfectSlayer

Copy link
Copy Markdown
Contributor Author

Add @mhlidd as reviewer for visibility :)

@dd-octo-sts

dd-octo-sts Bot commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.05 s 13.89 s [+0.3%; +2.0%] (maybe worse)
startup:insecure-bank:tracing:Agent 12.91 s 12.99 s [-1.3%; -0.0%] (maybe better)
startup:petclinic:appsec:Agent 16.85 s 16.67 s [-0.0%; +2.2%] (no difference)
startup:petclinic:iast:Agent 16.81 s 16.30 s [-2.5%; +8.8%] (unstable)
startup:petclinic:profiling:Agent 16.13 s 16.84 s [-8.5%; +0.1%] (no difference)
startup:petclinic:sca:Agent 16.86 s 16.74 s [-0.4%; +1.8%] (no difference)
startup:petclinic:tracing:Agent 15.99 s 15.95 s [-0.8%; +1.2%] (no difference)

Commit: e22db9a6 · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: context propagation Trace context propagation tag: no release notes Changes to exclude from release notes type: refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant