ci(profiling): Add more sanitizers#3989
Conversation
|
realFlowControl
force-pushed
the
florian/more-sanitizers
branch
from
0348dc4 to
d6c26b3
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d6c26b3fa4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
realFlowControl
force-pushed
the
florian/more-sanitizers
branch
4 times, most recently
from
d3704d7 to
852b766
Compare
realFlowControl
force-pushed
the
florian/more-sanitizers
branch
from
852b766 to
4441d72
Compare
| cd profiling/tests | ||
| cp -v $(php-config --prefix)/lib/php/build/run-tests.php . | ||
| export DD_PROFILING_OUTPUT_PPROF=/tmp/pprof | ||
| export ASAN_OPTIONS="${ASAN_OPTIONS:+$ASAN_OPTIONS:}abort_on_error=1:halt_on_error=1:detect_leaks=1:strict_string_checks=1:detect_stack_use_after_return=1:check_initialization_order=1:detect_container_overflow=1:detect_odr_violation=2:symbolize=1:disable_coredump=0:unmap_shadow_on_exit=1" |
There was a problem hiding this comment.
Why disable_coredump=0, if you do not collect the artifacts, though?
There was a problem hiding this comment.
Ah yeah, good catch. I was undecided between having a core dump and uploading it to the artifacts or not, so I decided for the middle way :-P
I'll open a follow-up PR and set disable_coredump=1.
2 participants
Description
This PR does multiple things:
.zstand not.lz4)Reviewer checklist