chore(telemetry): exclude OTLP headers from configuration telemetry#18497
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits intoJun 11, 2026
Merged
Conversation
bm1549
added
the
AI Generated
Contributor
|
bm1549
force-pushed
the
brian.marks/omit-sensitive-config-telemetry
branch
from
ce2db44 to
c665d22
Compare
Codeowners resolved as |
BenchmarksBenchmark execution time: 2026-06-09 22:49:49 Comparing candidate commit 9293b0c in PR branch Found 0 performance improvements and 3 performance regressions! Performance is the same for 618 metrics, 10 unstable metrics. scenario:iastaspects-strip_noaspect
scenario:iastaspectsospath-ospathbasename_aspect
scenario:span-start
|
bm1549
force-pushed
the
brian.marks/omit-sensitive-config-telemetry
branch
from
c665d22 to
9293b0c
Compare
mabdinur
approved these changes
Jun 10, 2026
…iguration telemetry Add a `sensitive: true` marker to the configuration registry and exclude any configuration carrying that marker from instrumentation configuration telemetry (the `configuration` array in app-started and app-client-configuration-change events). - supported-configurations.json: mark OTEL_EXPORTER_OTLP_HEADERS, OTEL_EXPORTER_OTLP_TRACES_HEADERS, OTEL_EXPORTER_OTLP_METRICS_HEADERS, OTEL_EXPORTER_OTLP_LOGS_HEADERS, DD_API_KEY, and DD_APP_KEY as `sensitive: true`, and regenerate _supported_configurations.py (adds SENSITIVE_CONFIGURATIONS). - scripts/supported_configurations.py: emit SENSITIVE_CONFIGURATIONS from the registry's `sensitive` attribute. - ddtrace/internal/telemetry/__init__.py: honor SENSITIVE_CONFIGURATIONS in both get_config() and report_configuration() so a sensitive config's value is not reported. Non-sensitive OTLP exporter configurations are still reported. DD_API_KEY/DD_APP_KEY were already read with report_telemetry=False; the marker documents that intent and their runtime behavior is unchanged. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
bm1549
force-pushed
the
brian.marks/omit-sensitive-config-telemetry
branch
from
54fd6e0 to
865d0b5
Compare
bm1549
added
the
changelog/no-changelog
gh-worker-dd-mergequeue-cf854d
Bot
merged commit 314cdf9
into
main
535 of 538 checks passed
gh-worker-dd-mergequeue-cf854d
Bot
deleted the
brian.marks/omit-sensitive-config-telemetry
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Marks the OpenTelemetry OTLP exporter header configurations as
sensitive: trueinsupported-configurations.jsonand excludes sensitive configurations from configuration telemetry:OTEL_EXPORTER_OTLP_HEADERS,OTEL_EXPORTER_OTLP_TRACES_HEADERS,OTEL_EXPORTER_OTLP_METRICS_HEADERS, andOTEL_EXPORTER_OTLP_LOGS_HEADERS. Other exporter configurations (endpoint, protocol, timeout) are unaffected.Testing
Unit tests in
tests/telemetry/test_writer.py.Risks
None.
Additional Notes
Release note included.