Skip to content

Emmett.butler/consolidate utils#18587

Draft
emmettbutler wants to merge 7 commits into
mainfrom
emmett.butler/consolidate-utils
Draft

Emmett.butler/consolidate utils#18587
emmettbutler wants to merge 7 commits into
mainfrom
emmett.butler/consolidate-utils

Conversation

@emmettbutler

Copy link
Copy Markdown
Collaborator

Description

Testing

Risks

Additional Notes

@emmettbutler emmettbutler marked this pull request as draft June 11, 2026 12:07
@emmettbutler emmettbutler requested a review from taegyunkim June 11, 2026 12:07
@cit-pr-commenter-54b7da

Copy link
Copy Markdown

Circular import analysis

🚨 New circular imports detected 🚨

The following circular imports among modules have been detected on this PR, when compared to the base branch:

ddtrace.internal.utils -> ddtrace.internal.utils -> ddtrace.internal.utils

Please consider refactoring your changes in accordance to the Separation of Concerns principle.

@datadog-prod-us1-3

datadog-prod-us1-3 Bot commented Jun 11, 2026

Copy link
Copy Markdown

Pipelines  Tests

Fix all issues with BitsAI

⚠️ Warnings

🚦 89 Pipeline jobs failed

Build | build_wheels / Build cp311-win_arm64   View in Datadog   GitHub Actions

Build | build_wheels / Build cp312-win_arm64   View in Datadog   GitHub Actions

Build | build_wheels / Build cp313-win_arm64   View in Datadog   GitHub Actions

View all 89 failed jobs.

ℹ️ Info

🔄 Datadog auto-retried 1 job - 0 passed on retry View in Datadog

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 02e5a7b | Docs | Datadog PR Page | Give us feedback!

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 02e5a7b2d3

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@@ -5,7 +5,7 @@
from typing import Optional

from ddtrace.internal.settings._agent import config as agent_config # noqa:F401
from ddtrace.internal.threads import RLock
from ddtrace.internal.utils.threads import RLock

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Restore the remaining encoding imports

This module still imports .compat and .logger a few lines below, but this commit removes ddtrace/internal/compat.py and ddtrace/internal/logger.py by moving them under ddtrace.internal.utils. As soon as ddtrace.internal.encoding is imported (the trace writers use these encoders), Python will raise ModuleNotFoundError before traces can be encoded; those relative imports need to be updated or compatibility shims kept.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant