Skip to content

Expand coverage for multieval paths#495

Closed
Anilm3 wants to merge 4 commits into
anilm3/multievalfrom
dd/anilm3/multieval-coverage-tests
Closed

Expand coverage for multieval paths#495
Anilm3 wants to merge 4 commits into
anilm3/multievalfrom
dd/anilm3/multieval-coverage-tests

Conversation

@Anilm3

@Anilm3 Anilm3 commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

What does this PR do?

Improve test coverage for the multieval/context-object-store changes by adding focused tests for missing success/error paths in context/subcontext eval APIs and object store queue behavior, and reconcile the branch with the latest baseline branch state.

Motivation

Recent multieval and queue-processing changes introduced new branches that were not fully exercised by tests. This update targets those uncovered paths to move patch coverage for the touched files toward full coverage and prevent regressions in context/subcontext evaluation behavior. The baseline branch also moved forward, so this update resolves merge conflicts to keep the PR reviewable.

Additional Notes

Changes were limited to tests and conflict reconciliation (no new functional behavior introduced beyond keeping baseline-side interface behavior during merge conflict resolution).

Files covered by the added tests:

  • tests/unit/object_store_test.cpp
  • tests/unit/evaluation_engine_test.cpp
  • tests/integration/interface/context/result/test.cpp
  • tests/integration/interface/context/multieval/test.cpp

Conflict reconciliation touched:

  • src/interface.cpp
  • tests/integration/context/test.cpp
  • tests/integration/interface/context/multieval/test.cpp

Coverage-focused additions include:

  • object_store insert-and-apply invalid input path
  • object_store queued batch flushing behavior (apply without marking targets as new)
  • context/subcontext map_view overload insertion paths
  • context/subcontext array_view multibatch invalid-shape paths
  • context/subcontext eval invalid object path when alloc is null
  • context/subcontext multieval internal error paths when user allocator throws

Describe how to test your changes

  • Resolve/refresh branch against baseline branch and ensure no unresolved conflict markers remain.
  • Attempted to build and run tests with:
    • cmake -S . -B build -DLIBDDWAF_TESTING=ON -DCMAKE_BUILD_TYPE=Debug
    • cmake --build build --target waf_test -j4
  • Build/test execution is currently blocked in this sandbox because external dependencies failed to download (HTTP 502 for googletest, yaml-cpp, and rapidjson).
  • Ran code quality checks on conflict-resolved files:
    • clang-format -i src/interface.cpp tests/integration/interface/context/multieval/test.cpp

Checklist

  • The CHAMGELOG.md has been updated
  • Unit tests have been updated and pass
  • If known, an appropriate milestone has been selected

PR by Bits - View session in Datadog

Comment @DataDog to request changes

@Anilm3 Anilm3 requested a review from a team as a code owner June 10, 2026 09:50
@datadog-official

datadog-official Bot commented Jun 10, 2026

Copy link
Copy Markdown

View session in Datadog

Bits Code status: ✅ Done

Comment @DataDog to request changes

@datadog-official

Copy link
Copy Markdown

I can only run on private repositories.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 15a02468a6

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/interface.cpp Outdated
Comment thread src/object_store.cpp
…/multieval-coverage-tests

# Conflicts:
#	src/interface.cpp
#	tests/integration/interface/context/multieval/test.cpp
@datadog-official

datadog-official Bot commented Jun 10, 2026

Copy link
Copy Markdown

Pipelines

Fix all issues with BitsAI

⚠️ Warnings

🚦 21 Pipeline jobs failed

Build | linux-musl-build (aarch64, linux/arm64)   View in Datadog   GitHub Actions

Build | linux-musl-build (armv7, linux/arm/v7)   View in Datadog   GitHub Actions

Build | linux-musl-build (i386, linux/386)   View in Datadog   GitHub Actions

View all 21 failed jobs.

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 370d936 | Docs | Datadog PR Page | Give us feedback!

@Anilm3 Anilm3 force-pushed the anilm3/multieval branch from 47ed904 to 41ad8b7 Compare June 10, 2026 10:27
@Anilm3 Anilm3 closed this Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant