Expand coverage for multieval paths#495
Closed
Anilm3 wants to merge 4 commits into
Closed
Conversation
|
Bits Code status: ✅ Done Comment @DataDog to request changes |
|
I can only run on private repositories. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 15a02468a6
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
…/multieval-coverage-tests # Conflicts: # src/interface.cpp # tests/integration/interface/context/multieval/test.cpp
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Improve test coverage for the multieval/context-object-store changes by adding focused tests for missing success/error paths in context/subcontext eval APIs and object store queue behavior, and reconcile the branch with the latest baseline branch state.
Motivation
Recent multieval and queue-processing changes introduced new branches that were not fully exercised by tests. This update targets those uncovered paths to move patch coverage for the touched files toward full coverage and prevent regressions in context/subcontext evaluation behavior. The baseline branch also moved forward, so this update resolves merge conflicts to keep the PR reviewable.
Additional Notes
Changes were limited to tests and conflict reconciliation (no new functional behavior introduced beyond keeping baseline-side interface behavior during merge conflict resolution).
Files covered by the added tests:
Conflict reconciliation touched:
Coverage-focused additions include:
Describe how to test your changes
cmake -S . -B build -DLIBDDWAF_TESTING=ON -DCMAKE_BUILD_TYPE=Debugcmake --build build --target waf_test -j4clang-format -i src/interface.cpp tests/integration/interface/context/multieval/test.cppChecklist
PR by Bits - View session in Datadog
Comment @DataDog to request changes