feat(properties): implement product properties - #19
Conversation
# Conflicts: # database/migrations/2025_08_08_082024_create_product_types_table.php
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #19 +/- ##
============================================
- Coverage 38.11% 35.40% -2.71%
- Complexity 635 779 +144
============================================
Files 55 68 +13
Lines 3138 4008 +870
============================================
+ Hits 1196 1419 +223
- Misses 1942 2589 +647 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
SlimDeluxe
left a comment
There was a problem hiding this comment.
- Include the property seeder in CatalogueSeeder.
- Value sorting should be done in the table with drag-and-drop, not with entering a value. See: https://filamentphp.com/docs/3.x/tables/advanced#reordering-records
- When viewing values, the language selector is empty
- When viewing values, do not show the property column.
- When editing a value, do not show the property input, and show the edit in a modal dialog instead of a full page. The remaining 3 inputs should span the dialog width and not be split in 2 columns like now.
- When editing a property, "Max values" should be a integer input.
- When viewing the value table, breadcrumb should be: Properties > Brand > List
(Properties should obv. link to prop table and not values)
|
Additional notes for the "product type edit" screen:
|
…atalogue-plugin into feat/properties
SlimDeluxe
left a comment
There was a problem hiding this comment.
- When editing a prop value in the prop edit screen, the value is not deserialized, and the sort field is shown (which should not be). Shouldn't this modal be the same as when editing the value from the value table?
- This section thing is not needed here. The dialog should be the same as for "New property value".
-
When editing a property, it would be better if the values were shown in a tab and table loading is deferred (done only when the user views the tab — if it's not too complicated).
-
The property part of the breadcrumb should be clickable and should take you to the "edit property" screen.
-
In the "Product type edit" screen, the form allows adding duplicate properties, but then throws an SQL error. Please see if you can narrow the selection to properties that have not been yet added to the type.
-
When removing a prop from the type, the dialog should use the term "Remove" instead of "Detach".

No description provided.