Update Lagoon vaults Incentives computation#2625
Open
GuiDupont wants to merge 10 commits into
Open
Conversation
Sum incentives[].apr + airdrops[].apr directly instead of deriving apyReward from (linearNetApr - linearNetAprWithoutExtraYields), which also includes native yield. DefiLlama's apyReward should represent reward incentives only, not yield intrinsic to the underlying asset.
…eld-from-reward fix(lagoon): split apyBase/apyReward and exclude native yield
Contributor
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThe Lagoon adapter's GraphQL query now extracts additional APR data for incentives and airdrops. The mapping logic reassigns Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Error while running lagoon adapter: Test Suites: 1 failed, 1 total |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/adaptors/lagoon/index.js`:
- Around line 74-81: Guard against null/missing lists from vault.state.weeklyApr
by making sumApr tolerant of null: change the helper sumApr so it accepts a
possibly-null input (e.g., const sumApr = (items = []) => items.reduce(...)) or
explicitly default incentives/airdrops to [] when calling sumApr; keep the
existing apyReward logic (sumApr(incentives) + sumApr(airdrops) || null) so a
zero total still yields null. Update the symbols: sumApr, incentives, airdrops,
apyReward, and vault.state.weeklyApr accordingly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 7597a5a2-a27a-49e5-b8d9-4646edd87629
📒 Files selected for processing (1)
src/adaptors/lagoon/index.js
|
Error while running lagoon adapter: Test Suites: 1 failed, 1 total |
Fix/no apy vault
|
The lagoon adapter exports pools: Test Suites: 1 passed, 1 total |
0xkr3p
reviewed
May 3, 2026
Contributor
0xkr3p
left a comment
0xkr3p
left a comment
There was a problem hiding this comment.
hey @GuiDupont, thanks for the PR, just a comment to resolve and pls remove package-lock.json file from PR
| apyBase: vault.state.weeklyApr.linearNetAprWithoutExtraYields, | ||
| apyBase, | ||
| apyReward, | ||
| tvlUsd: vault.state.totalAssetsUsd || 0, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit