fix: re-enable jones-dao adapter (deposits resumed)#2632
Open
0xIvan wants to merge 1 commit into
Open
Conversation
jones-dao was excluded in DefiLlama#2348 with reason "disabled deposits". That's no longer accurate — vaults are open and accruing TVL: - jAURA: ~$18k TVL, ~66% APY (lsdVault) - jUSDC: ~$749k TVL, ~1.6% APY - smart-lp: 164 active strategies across 7 chains - jGLP: 0 TVL (winding down) but APY still reported by API Two changes: 1. Drop 'jones-dao' from src/utils/exclude.js so the project's pools surface again. 2. In src/adaptors/jones-dao/index.js, remove the `vault.tvl > 0` guard on jGLP so the pool keeps emitting at 0 TVL. This preserves the historical chart on DefiLlama while jGLP winds down; the API still returns a valid APY for legacy positions. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThe jones-dao adapter is re-enabled by removing it from the hardcoded exclusion list. Its vault pool logic is modified to include all leveraged vaults regardless of TVL value, whereas previously only vaults with Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The jones-dao adapter exports pools: Test Suites: 1 passed, 1 total |
0xkr3p
requested changes
Apr 29, 2026
Contributor
0xkr3p
left a comment
0xkr3p
left a comment
There was a problem hiding this comment.
hi @0xIvan, thanks for your PR. After looking at https://app.jonesdao.io/vaults it appears jUSDC and jGLP are still disabled. Are you re-enabling deposits for these vaults? otherwise they will have to be excluded at a pool level (see here: https://github.com/DefiLlama/yield-server/blob/master/src/utils/exclude.js#L2242). Please add the pool values to the above list.
After excluding the disabled pools, the adapter can be included and serve with the active pools: jAURA and Smart LPs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
jones-daoadapter was excluded in #2348 (Feb 2026) with the reason//disabled deposits. That's no longer accurate — Jones vaults are open, accruing TVL, and the adapter is producing valid pool data. This PR re-enables it and ensures jGLP's historical chart stays visible while that vault winds down.Live state pulled from Jones APIs at PR time:
Running the adapter locally now emits 167 pools, all of which were silently dropped at the enrichment layer because of the project-level exclusion.
Changes
src/utils/exclude.js— remove'jones-dao', //disabled deposits. The reason no longer applies; deposits are open across jAURA, jUSDC, and smart-lp.src/adaptors/jones-dao/index.js— remove thevault.tvl > 0guard on jGLP. The vault is winding down so live TVL is 0, but the upstream API still reports a valid APY for residual positions, and we want DefiLlama's historical chart for jGLP to remain visible rather than disappearing once the project is un-excluded.Test plan
node -e "require('./src/adaptors/jones-dao').apy().then(p => console.log(p.length))"— returns 167 poolstvlUsd/apyBase🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
Updates