feat(converters,utils): add support for vector quantities in TIM file conversion - #1209
Open
riordache12 wants to merge 2 commits into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
The following description of the expected result comes from Julien.
There are some quantities that can have similarly have multiple columns in the *.tim file, some examples:
For some it is known that it is always 2 or 3 columns (time, windx, windy) for other it depends on the number of constituents (discharge_salinity_temperature_sorsin)
For uxuyadvectionvelocitybnd, I suggest converting to:
I've used model:
c011_san_francisco_bay_3din order to test and debug. I've noticed that the quantity names and units were not displayed so I've introduced them insidedata.yaml, in a similar fashion with how you have introducedold_to_new_quantity_namesin the past. I'm validating if that format is respected. Then I use that definition to create aForcingBlockthat would comprise everything, but I only do it if those vectors are specified, otherwise the functionality remains unchanged.Tests still need to be generated.
uxuyadvectionvelocitybndboundary condition with two columns in the tim file gives an error #761Check relevant points.
How Has This Been Tested?
Checklist:
Prepare items below using:
[ ❌ ] (markdown:
[ :x: ]) for TODO items[ ✅ ] (markdown:
[ :white_check_mark: ]) for DONE items[ N/A ] for items that are not applicable for this PR.