Surfacewater infiltration - #843
Open
JoostBuitink wants to merge 33 commits into
Open
JoostBuitink wants to merge 33 commits into
JoostBuitink wants to merge 33 commits into
Conversation
JoostBuitink
marked this pull request as ready for review
April 10, 2026 15:27
vers-w
requested changes
May 11, 2026
vers-w
left a comment
vers-w
left a comment
Collaborator
There was a problem hiding this comment.
Nice work and very useful new feature!
Besides the comments below I was wondering if re-infiltration of overland flow affects the water mass balance error significantly? If I remember correctly, this was a concern when working on this in another branch. Also, I think the changelog has not been updated yet?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue addressed
Fixes #
Explanation
Explain how you addressed the bug/feature request, what choices you made and why.
Checklist
masterAdditional Notes (optional)
Add any additional notes or information that may be helpful.