[fix][misc] Fix Backoff mandatory-stop timer tracking#23
Open
Denovo1998 wants to merge 4 commits into
Open
Conversation
5 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #23 +/- ##
=============================================
+ Coverage 30.86% 72.68% +41.81%
- Complexity 51 34073 +34022
=============================================
Files 1862 1959 +97
Lines 146347 155552 +9205
Branches 17011 17741 +730
=============================================
+ Hits 45171 113056 +67885
+ Misses 94161 33483 -60678
- Partials 7015 9013 +1998
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
# Conflicts: # pulsar-common/src/main/java/org/apache/pulsar/common/util/Backoff.java # pulsar-io/kinesis/src/main/java/org/apache/pulsar/io/kinesis/Backoff.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: https://github.com/apache/pulsar/pull/25278/changes#r2878215799
Main Issue: #xyz
PIP: #xyz
Motivation
Backoff's mandatory-stop timer can be unintentionally reset when
current == initial, which happens with constant backoff (initial == max) and afterreduceToHalf()bringsnextback toinitial. This preventsmandatoryStopMadefrom ever being reached and can cause retries to run longer than the configured mandatory stop.Modifications
reset().Verifying this change
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: apache#25282