[feat][cli] Add fault scenario controls to pulsar-perf#28
Open
Denovo1998 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #xyz
Main Issue: #xyz
PIP: #xyz
Motivation
pulsar-perfis useful for generating producer, consumer, and reader traffic during performance tests and operational drills. However, it cannot currently model several common client-side production failure patterns directly, such as consumers that receive messages but do not ack, consumers that ack slowly after per-message processing delay, fixed-key partition hot spots, or producer pending-queue behavior that fails instead of blocking.This PR adds these client-side controls to the existing
produceandconsumecommands so operators can reproduce those scenarios withpulsar-perfinstead of writing one-off custom clients. The default behavior remains unchanged.Modifications
--message-keytopulsar-perf produceto publish all messages with a fixed key for key-skew and hot-partition simulations.--message-routing-modetopulsar-perf produce, supportingRoundRobinPartitionandSinglePartition, while rejecting unsupportedCustomPartitionusage from the CLI.--block-if-queue-fulltopulsar-perf produce, defaulting to the existing blocking behavior and allowing failure-oriented pending-queue simulations when set tofalse.--ack-mode,--processing-delay-millis, and--ack-timeout-millistopulsar-perf consumeto support normal ack, no-ack, slow-ack, and ack-timeout redelivery simulations.Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes