Make perspective-correction at 1x resolution usable before using a higher resolution - #150
Open
72374 wants to merge 1 commit into
Open
Conversation
so that perspective-correction can work properly.
Owner
|
Not sure how much visual benefit this brings. But you caught an inconsistency. I'll add it to the next release. (No ETA, but I'm working on things) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Perspective-correction does not work properly until
cacheMode7HD()has been used; which does happen while the scale-setting is set to 2x or higher, but not while it is set to "1x 224p" (ppu.hdScale() = 1) or "disable" (ppu.hdScale() = 0)."1x 224p" is for using enhancements at the original resolution, so using
cacheMode7HD()is also necessary then, so that perspective-correction can work properly.Image-comparison (F-Zero)
Without this change:
With this change:
It may be necessary to restart bsnes-hd after changing the scale-setting to 1x, for the issue, that this change solves, to happen.