Add maxLiteralStringLength as a configuration property#1656
Open
Minibrams wants to merge 5 commits into
Open
Conversation
Author
|
@DetachHead This touches a lot of stuff, so it will probably be a huge pain to merge with future pyright releases... |
DetachHead
reviewed
Nov 28, 2025
|
|
||
| **basedpyright.analysis.fileEnumerationTimeout** [integer]: Timeout (in seconds) for file enumeration operations. When basedpyright scans your workspace files, it can take a long time in some workspaces. This setting controls when to show a "slow enumeration" warning. Default is 10 seconds. | ||
|
|
||
| **basedpyright.analysis.maxLiteralStringLength** [integer]: Maximum number of characters to show for string literals in hovers, completions, etc. Defaults to `50`. |
Owner
There was a problem hiding this comment.
i think instead of adding a config option we should add an option to the type printer to not truncate the string at all if it's for a completion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We introduce a new configuration property
maxLiteralStringLengththat fixes #1416 and #1655.The property can be set either in the serverSettings (e.g.
.vscode/settings.json):{ "basedpyright.analysis.maxLiteralStringLength": 100 }or in the
pyproject.toml:or in the
pyrightconfig.json:{ "maxLiteralStringLength": 100 }Know issues
It looks like we can't control the render-length of completion suggestions, which is unfortunate. However, even though completion suggestions are still truncated after 50 characters, the effective value on auto-complete respects the configuration property.