feat(client): emoji reaction picker on Android (beta blocker 5/5)#598
Merged
Conversation
The message context menu's "React" action previously did nothing. It now opens a modal emoji picker (a curated set of 16 common reactions in a 4-column grid); choosing one calls the existing add-reaction API via the view model. - EmojiPicker: AlertDialog + LazyVerticalGrid of tappable emoji - Reactions: the curated COMMON_REACTIONS list, kept Compose-free so it is unit testable - TextChannelScreen: holds the reaction-target message id and shows the picker, wiring selection to onAddReaction - ReactionsTest: list is non-empty, duplicate-free, non-blank, grid-even Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Android beta blocker 5/5 — the final one. Reacting to messages now works.
The message long-press context menu already had a "React" item, but it was a no-op (
onReactwas a stub). It now opens a modal emoji picker; selecting an emoji calls the existingTextChannelViewModel.onAddReaction→ChatRepository.addReaction→MessageApi.addReactionchain (all of which already existed).What's new
EmojiPicker— anAlertDialogcontaining a 4-columnLazyVerticalGridof tappable emoji, with a Cancel button and tap-outside/back dismissal.Reactions.kt— the curatedCOMMON_REACTIONSlist (16 common reactions: 👍 👎 ❤️ 😂 😮 😢 😡 🎉 🔥 👏 🙏 💯 🚀 👀 ✅ ❓), kept deliberately Compose-free so it loads in a plain JVM unit test.TextChannelScreen— holds thereactionTargetIdfor the message being reacted to, shows the picker when set, and forwards the chosen emoji to the view model.Tests
ReactionsTest— the reaction set is non-empty, duplicate-free, all-non-blank, and a clean multiple of the 4-column grid width.Milestone
This completes the Android beta blockers (markdown #594, attachments #595, unread indicators #596, DM UI #597, reaction picker — this PR). The five blocker features defined in the Android Beta milestone are now all shipped.
🤖 Generated with Claude Code