fix(cli): apply client selector to registry integrations (#1798) - #1802
fix(cli): apply client selector to registry integrations (#1798)#1802rarepops wants to merge 1 commit into
Conversation
Signed-off-by: Rares Popa <2606875+rarepops@users.noreply.github.com>
|
Thanks for opening this — it has been seen, and it is queued. This note is automated, but it is not a brush-off: it exists so you know where your PR stands instead of having to guess from silence. Current review status: working through a backlog. What that means for this PR, concretely:
Things that will genuinely speed it up whenever review does happen:
If this fixes a bug, a reproduction we can run is worth more than a description of the symptom. Thanks for contributing, and sorry in advance for the wait. |
|
Thank you for the focused selector fix and regression coverage. I checked current I have labeled this as a high-priority editor-integration bug and queued it for review. CI is green. Our review queue is full, so detailed review may take a little time, but the PR is now classified and routed. Thank you for preserving the selector's restrictive semantics rather than force-enabling undetected clients. |
What does this PR do?
Fixes #1798.
--clientspreviously filtered only the legacy client table, so registry-backed clients such as Qoder and Rovo Dev were still detected and configured. This change makes registry stable IDs part of the selector vocabulary and applies the same restriction to registry detection output and installation.The selector remains restrictive: it configures only selected clients that are detected, and does not force-enable undetected clients.
Validation covered the sanitizer build and both selector regressions. The full CLI suite passes with 283 tests. clang-format 20.1.8 and
git diff --checkpass; focused cppcheck reports only pre-existing style findings in test helpers and older test code.Checklist
git commit -s) - required, CI rejects unsigned commits (DCO, see CONTRIBUTING.md)cli: 283 passed)make -f Makefile.cbm lint-ci) - upstreamlint / lintandlint / lint-memchecks pass