Use elevator NuGet assets for Windows release packaging#4567
Use elevator NuGet assets for Windows release packaging#4567Gabriel Dufresne (GabrielDuf) merged 3 commits intomainfrom
Conversation
|
The installer now doesn't fail on ARM 64 when installing the MSVC Runtime ;-) |
| procedure Dependency_AddVC2015To2022; | ||
| begin | ||
| // https://docs.microsoft.com/en-us/cpp/windows/latest-supported-vc-redist | ||
| if not IsMsiProductInstalled(Dependency_String('{36F68A90-239C-34DF-B58C-64B30153CE35}', '{36F68A90-239C-34DF-B58C-64B30153CE35}'), PackVersionComponents(14, 30, 30704, 0)) then begin |
There was a problem hiding this comment.
Marc-André Moreau (@mamoreau-devolutions) I found an issue. The installer keeps installing the MSVC Runtime over and over. I think it was my mistake. The URLs below are correct, but these GUIDs also need to change. I'll try to find it and I'll post it here.
There was a problem hiding this comment.
The product code is {91ee571b-0e8a-4c65-9eaf-2e2f5fc60c00}
There was a problem hiding this comment.
Let me know if you find anything, I installed it once on arm64, but I didn't try reinstalling to see if it would keep installing the msvc runtime
There was a problem hiding this comment.
Try installing again, you'll see it starts the MSVC runtime again. Do you want me to open a PR to change the product GUID? Or you will change it yourself? The new GUID is {91ee571b-0e8a-4c65-9eaf-2e2f5fc60c00}
There was a problem hiding this comment.
If you open a pull request before tomorrow it'll save me a bit of trouble, but if it's just changing the update code it's a small thing I can do
3 participants
Summary
getfilesiginforedist.dlland update installer to install ARM64 extras #4564 for Windows release buildsUniGetUI Elevator.exeandgetfilesiginforedist.dllfromDevolutions.UniGetUI.ElevatorDevolutions.UniGetUI.Elevatorto2.6.1.1, which now carries the platform-specificgetfilesiginforedist.dllsrc/UniGetUI/Assets/Utilities/getfilesiginforedist.dllDetails
This ports the Windows packaging changes introduced in #4564, but adjusts the final DLL handling for this branch:
getfilesiginforedist.dllunder repo assets, the WinUI project now imports it directly from the elevator NuGet package for bothx64andarm64getfilesiginforedist.dlland update installer to install ARM64 extras #4564 updates for the VC++ redistributable URL and ARM64 WebView2 runtime selectionValidation
Build and Releaserun24200471971UniGetUI-release-x64andUniGetUI-release-arm64Assets/Utilities/UniGetUI Elevator.exeandAssets/Utilities/getfilesiginforedist.dllDevolutions.UniGetUI.Elevator 2.6.1.1NuGet payload by SHA-256 hashUniGetUI Elevator.exe: signed byDevolutions Incgetfilesiginforedist.dll: signed byMicrosoft CorporationUniGetUI.exeand installer executables unsigned, which is expected because signing steps are skipped whendry-run=true