Skip to content

Don't report 'tis, 'twould, etc. #1918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
windymilla merged 1 commit into from
Aug 2, 2026
Merged

Don't report 'tis, 'twould, etc. #1918

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 17 additions & 5 deletions src/guiguts/misc_tools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2261,6 +2261,10 @@ def library_regexes() -> None:
"'Twon't",
"'Tain't",
)
CURLY_APOS_WORDS = [word.replace("'", "’") for word in INIT_APOS_WORDS]
INIT_APOS_WORDS_RE = re.compile(rf"{'|'.join(CURLY_APOS_WORDS)}(?!\w)", re.IGNORECASE)
INIT_APOS_LEN = len(max(CURLY_APOS_WORDS, key=len))

SAFE_APOS_RQUOTE_REGEXES = (
r"(?<=\w)'(?=\w)", # surrounded by letters
r"(?<=[\.,\w])'", # preceded by period, comma or letter
Expand Down Expand Up @@ -2627,18 +2631,26 @@ def add_quote_entry(prefix: str) -> None:
last_open_single_idx = match.rowcol.index()
elif match_text == SQUOTES[1]: # Close single
context = maintext().get(
f"{match.rowcol.index()}-2c", f"{match.rowcol.index()}+3c"
f"{match.rowcol.index()}-1c",
f"{match.rowcol.index()}+{INIT_APOS_LEN}c",
)
# If letters both sides, it's an apostrophe, so ignore
if len(context) < 5 or context[1].isalpha() and context[3].isalpha():
if (
len(context) < INIT_APOS_LEN
or context[0].isalpha()
and context[2].isalpha()
):
continue
# If one of the known initial apostrophe words, ignore it
if INIT_APOS_WORDS_RE.match(context[1:]):
continue
if sqtype == 0:
add_quote_entry("Close SQ unexpected (apos?): ")
elif context[1] == "\n":
elif context[0] == "\n":
add_quote_entry("Close SQ at line start (apos?): ")
elif context[1] == " ":
elif context[0] == " ":
add_quote_entry("Close SQ after space (apos?): ")
elif context[3].isalnum():
elif context[2].isalnum():
add_quote_entry("Close SQ before letter (apos?): ")
sqtype = 0
elif match_text == '"': # Straight double
Expand Down
Loading