Skip to content

restore ORTHANC_VERSION for container image tag #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hurngchunlee merged 2 commits into from
Jun 19, 2026
Merged

restore ORTHANC_VERSION for container image tag #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c0deeff
added missing ORTHANC_VERSION
hurngchunlee Jun 19, 2026
cd125d4
removed ORTAHNC_VERSION from env file
hurngchunlee Jun 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .github/workflows/release-docker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,20 @@ jobs:
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}

- name: Extract ORTHANC_VERSION from Dockerfile
run: |
set -eu
orthanc_version="$(sed -nE 's|^FROM[[:space:]]+jodogne/orthanc:([^[:space:]]+)[[:space:]]+AS[[:space:]]+orthanc$|\1|p' docker/Dockerfile | head -n 1)"
if [ -z "$orthanc_version" ]; then
echo "Failed to parse ORTHANC_VERSION from docker/Dockerfile" >&2
exit 1
fi
echo "ORTHANC_VERSION=$orthanc_version" >> "$GITHUB_ENV"

- name: Build and push application images
working-directory: docker
env:
ORTHANC_VERSION: ${{ env.ORTHANC_VERSION }}
DOCKER_IMAGE_TAG: ${{ github.event.release.tag_name || 'latest' }}
run: |
docker compose build orthanc wlbroker cal2wl
Expand Down
3 changes: 0 additions & 3 deletions docker/env.example
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,6 @@
## docker registry endpoint
#DOCKER_REGISTRY=dccn

## ORTHANC version, defining the version of ORTHANC the `dicomdf-orthac` is based on
#ORTHANC_VERSION=1.4.2

## volume for Orthanc configurations, read-only bind mounted to /var/lib/orthanc/etc
#VOL_ORTHANC_CONFIG=./orthanc/config

Expand Down
Loading