Support variable-TR, variable-flip-angle protocols in MCR-MWI processing and fitting - #42
Open
samuelmelke wants to merge 4 commits into
Open
samuelmelke wants to merge 4 commits into
samuelmelke wants to merge 4 commits into
Conversation
Collaborator
|
Hi Samuel, can you do your pull request against |
Collaborator
Author
|
Done. |
| path = dependencies/Tensor-MP-PCA | ||
| url = https://github.com/Neurophysics-CFIN/Tensor-MP-PCA.git | ||
| branch = main | ||
| [submodule "dependencies/vTR-qMRI"] |
Collaborator
There was a problem hiding this comment.
Question, did you manually edit the .gitmodules file or did you use:
$ git submodule add -b main https://github.com/samuelmelke/vTR-qMRI.git dependencies/vTR-qMRI
I'm asking because I had created a lot of issues myself in the past when I edited the file manually...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for variable-TR, variable-flip-angle protocols in the MCR-MWI
preprocessing and fitting stages. Constant-TR behaviour is unchanged.
+qb/+workers/VFAprepWorker.m—make_syntheticT1_M0assumed one TR forall flip angles: DESPOT1 was fitted with whichever TR was read last, and every
synthetic T1w target was built with that same TR. It now reads
RepetitionTimeper flip alongsideFlipAngleand dispatches on whether theTRs differ:
despot1_mappingfor constant TR,despot1_VTRfor variable TR.GRESignaltakes the per-flip TR, which is identical to the previousbehaviour when the TRs are equal.
+qb/+workers/MCR_GPUWorker.m— detects a variable protocol (differingTR, echo counts, or TE grids across flips) and dispatches to
gpuMCRMWI_VFAVTRinstead ofgpuMCRMWI, concatenating echoes along dim 4with a
te_indexrangemapping so unequal echo trains per flip are handled..gitmodules/dependencies/vTR-qMRI— adds vTR-qMRI as a submodule,providing
despot1_VTRandgpuMCRMWI_VFAVTR.