DYN-10119: Add IValueSchemaProvider and typeIds to DefineData

[kalunkuo]

Purpose

Expose wire-format $typeid values from DataNodeDynamoType through a new public IValueSchemaProvider interface, so DynamoPlayer and DynamoMCP can programmatically resolve the canonical type identifier for DefineData nodes.

Previously, external consumers (DynamoPlayer, MCP) had no programmatic way to get the $typeid that ProtoGeometry's ToJson() emits for a given DefineData type. They relied on display names (e.g. "Point") and maintained separate hardcoded lookup dictionaries, which drifted from actual wire values.

Related PRs: DynamoPlayer (reads ValueTypeId via reflection) and DynamoMCP (resolves typeIds to JSON Schemas for LLM consumers).

Key changes:

• New IValueSchemaProvider interface in DynamoCore/Graph/Nodes/ with ValueTypeId (string) and IsListValue (bool)
• DefineData implements IValueSchemaProvider, returning DataNodeDynamoType.TypeId via ValueTypeId
• DataNodeDynamoType gains a TypeId property populated with the actual wire-format $typeid for each supported type (e.g. "autodesk.math:point3d-1.0.0" for Point, "autodesk.geometry.curve:circle-1.0.0" for Arc/Circle)
• Wire-format typeIds verified against actual StringifyJSON output — see Sample.json attached to the Jira ticket
• PublicAPI.Unshipped.txt updated with the 3 new public API members

Declarations

Check these if you believe they are true

• Is documented according to the standards
• The level of testing this PR includes is appropriate
• Changes to the API follow Semantic Versioning and are documented in the API Changes document.

Release Notes

Expose wire-format $typeid values from DataNodeDynamoType through a new public IValueSchemaProvider interface

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

[github-actions]

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-10119

[Copilot]

Pull request overview

This PR adds a new public API surface to expose a stable, wire-format type identifier ($typeid) for DefineData nodes so external consumers (e.g., DynamoPlayer, DynamoMCP) can resolve canonical type identifiers without relying on display names.

Changes:

• Introduces Dynamo.Graph.Nodes.IValueSchemaProvider with ValueTypeId and IsListValue.
• Extends DSCore.Data.DataNodeDynamoType with a TypeId field populated for supported types and wires those IDs into the supported type list.
• Implements IValueSchemaProvider on CoreNodeModels.DefineData and updates DynamoCore/PublicAPI.Unshipped.txt.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File	Description
src/Libraries/CoreNodes/Data.cs	Adds TypeId to supported data types and populates wire-format $typeid strings.
src/Libraries/CoreNodeModels/DefineData.cs	Implements IValueSchemaProvider to expose typeId/list context from the dropdown selection.
src/DynamoCore/Graph/Nodes/IValueSchemaProvider.cs	Adds the new public interface for external consumers to query schema/type info.
src/DynamoCore/PublicAPI.Unshipped.txt	Registers the new public interface members for API analyzer compliance.

[RobertGlobant20]

Just some minor comments LGTM,

[RobertGlobant20]

So based in the comment in IValueSchemaProvider.cs it will return null or "null"?.

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud