DYN-9801, DYN-6762: Update libg#17079
Open
aparajit-pratap wants to merge 1 commit intomasterfrom
Open
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-9801
Contributor
There was a problem hiding this comment.
Pull request overview
Updates LibG NuGet package references across Dynamo projects to pick up C++ localization modernization changes and the Mesh.ExtrudePolyCurve fix delivered via LibG.
Changes:
- Bump
DynamoVisualProgramming.LibG_232_0_0from4.0.0.4684to4.0.0.4815across libraries, tools, and test projects. - Update
DynamoCoreto useLibG_232_0_0/LibG_232_0_0_debug4.0.0.4815andLibG_231_0_04.0.0.4795.
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/Libraries/WorkflowTests/WorkflowTests.csproj | Updates LibG_232 package version for workflow tests. |
| test/Libraries/TestServices/TestServices.csproj | Updates LibG_232 package version for shared test services. |
| test/Libraries/TessellationTests/TessellationTests.csproj | Updates LibG_232 package version for tessellation tests. |
| test/Libraries/GeometryColorTests/GeometryColorTests.csproj | Updates LibG_232 package version for geometry color tests. |
| test/Libraries/DynamoPythonTests/DynamoPythonTests.csproj | Updates LibG_232 package version for Python-related tests that depend on geometry. |
| test/Libraries/AnalysisTests/AnalysisTests.csproj | Updates LibG_232 package version for analysis tests. |
| src/Tools/NodeDocumentationMarkdownGenerator/NodeDocumentationMarkdownGenerator.csproj | Updates LibG_232 package version for the doc generator tool. |
| src/Libraries/Tesellation/Tessellation.csproj | Updates LibG_232 package version for the tessellation library. |
| src/Libraries/GeometryUIWpf/GeometryUIWpf.csproj | Updates LibG_232 package version for WPF geometry UI components. |
| src/Libraries/GeometryUI/GeometryUI.csproj | Updates LibG_232 package version for geometry UI components. |
| src/Libraries/GeometryColor/GeometryColor.csproj | Updates LibG_232 package version for geometry color library. |
| src/Libraries/CoreNodes/CoreNodes.csproj | Updates LibG_232 package version for core nodes that depend on geometry. |
| src/Libraries/Analysis/Analysis.csproj | Updates LibG_232 package version for analysis library. |
| src/DynamoManipulation/DynamoManipulation.csproj | Updates LibG_232 package version for manipulation components. |
| src/DynamoCoreWpf/DynamoCoreWpf.csproj | Updates LibG_232 package version for core WPF UI. |
| src/DynamoCore/DynamoCore.csproj | Updates LibG_231 and LibG_232 (release/debug) package versions used by the core engine build targets. |
|
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Update LibG for C++ localization modernization changes and fixes for
Mesh.ExtrudePolyCurve.Declarations
Check these if you believe they are true
Release Notes
Fixed extrusion of open PolyCurves producing incorrect mesh geometry.
Reviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of