-
Notifications
You must be signed in to change notification settings - Fork 96
Add water tracers #638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
billsacks
wants to merge
85
commits into
ESCOMP:main
Choose a base branch
from
billsacks:water_tracers
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Add water tracers #638
Changes from 78 commits
Commits
Show all changes
85 commits
Select commit
Hold shift + click to select a range
609fe84
Scripting and xml changes for flexible water tracers/isotopes
billsacks 3b0470a
Use '-' rather than empty string for tracers of bulk water
billsacks 59b1110
Correctly handle empty WATER_TRACERS
billsacks 52c8265
Initialize water tracers
billsacks 1493db2
Merge remote-tracking branch 'origin/main' into water_tracers
billsacks 78a8921
Add wtracer versions of necessary fields to fd_cesm.yaml
billsacks 0f793bd
Remove some fields from fd_cesm.yaml that no longer exist
billsacks e908b10
Add checks of water tracers
billsacks 1fb3288
Merge remote-tracking branch 'origin/main' into water_tracers
billsacks 0d290e8
Merge branch 'refactor_med_methods_fb_init' into water_tracers
billsacks 55a889b
Merge branch 'refactor_med_methods_fb_init' into water_tracers
billsacks af4fc3d
Revert "For now, hard-code n_tracers = 0"
billsacks a7c7bbb
Add first set of water tracer fields (for evap fields)
billsacks 864926a
Merge branch 'remove_duplicate_flds_exchange' into water_tracers
billsacks 4cfb22a
Add qref water tracer fields
billsacks 0adffa2
Add Sa_shum water tracer fields
billsacks 859d299
Merge branch 'refactor_med_methods_fb_init' into water_tracers
billsacks b3e351c
Move fetch of n_tracers into is_tracer conditional
billsacks 5d7defb
Merge branch 'refactor_med_methods_fb_init' into water_tracers
billsacks 16d28d7
Wrap shr_wtracers_get_num_tracers
billsacks a371620
Merge branch 'main' into water_tracers
billsacks dc7da27
Wrap / stub more things from shr_wtracers to break dependencies
billsacks 2ac4d2f
Merge branch 'main' into water_tracers
billsacks bb60780
Put code for water tracers in a loop over bulk & tracers
billsacks 5c7b931
Rename some variables
billsacks f0beaf9
Make some things private
billsacks 04e3c3f
Add So_roce_wtracers field
billsacks 5946090
Add water tracer fields for rain and snow fields
billsacks 24096a5
Add water tracer field for Fioi_meltw
billsacks a3857ad
Add water tracer field for Flrl_irrig
billsacks 71b32ab
Merge branch 'refactor_field_creation' into HEAD
billsacks 99fc8c7
Merge branch 'refactor_field_creation' into water_tracers
billsacks 1c0674b
Add water tracers for remaining Flrl fields
billsacks cdcc907
Add tracer fields for Fgrg fields
billsacks 143e653
Merge remote-tracking branch 'origin/main' into water_tracers
billsacks 5619722
Add tracer versions of some runoff fields
billsacks daaeada
Merge branch 'post_rof_fields_with_ungridded_dims' into water_tracers
billsacks 4f4fe7a
Add water tracer fields for Flrr_volr and Flrr_volrmch
billsacks daa5764
Add tracer fields for Flgl_qice and Flgl_qice_elev
billsacks 53f76b3
Extend med_methods_FB_check_wtracers to work with rank-2 fields
billsacks e40197b
Add a testmod to test glc coupling
billsacks ea82f1c
Merge branch 'main' into water_tracers
billsacks c6bd408
Merge branch 'handle_rank3_fields' into water_tracers
billsacks 7457f7e
Add interfaces to some shr_wtracer things that we'll need in prep_glc
billsacks bf58f92
Remove unnecessary duplicate resetting of FBlndAccum2glc_g
billsacks df3676e
Use med_methods_FB_accum in med_phases_prep_glc_accum_lnd
billsacks af43baf
Use med_methods in med_phases_prep_glc_avg
billsacks 4ca7bcd
Handle water tracers in most of med_phases_prep_glc_mod
billsacks 8aaa908
Turn on glc_renormalize_smb even for X compsets
billsacks 5952845
Change dimension order convention for rank-3 tracer fields
billsacks 7a3598a
Extract routines to calculate sums in renormalize_smb
billsacks b418781
Do SMB renormalization on tracers as well as bulk
billsacks 9695e26
Merge branch 'handle_rank3_fields' into water_tracers
billsacks bd6235a
Merge branch 'main' into water_tracers
billsacks 8b259ae
Merge branch 'add_x_comps' into water_tracers
billsacks 0d05065
Remove an xrof coupling field that no longer exists
billsacks 74627eb
Change xcomp logic for including field number
billsacks 26c554e
Make a shared routine, set_all_export_fields
billsacks ad7e058
Add code to nuopc xcomps to create and set water tracer fields
billsacks c1dba82
xcpl_comps_nuopc: Add first set of water tracer fields (for evap fields)
billsacks 38543e0
xcpl_comps_nuopc: Add qref water tracer fields
billsacks 07a6873
xcpl_comps_nuopc: Add Sa_shum water tracer fields
billsacks 03c49fd
Add So_roce_wtracers
billsacks 8e01401
In X comps, add water tracer fields for rain and snow
billsacks c3d37a6
X comps: add water tracer field for Fioi_meltw
billsacks 208919c
X comps: add water tracer field for Flrl_irrig
billsacks 0ff0963
Add water tracers for remaining Flrl fields
billsacks f685f74
Xcomps: add Fgrg fields
billsacks 6566dab
X comps: add Fioi_meltw to ocn
billsacks 94b2ed0
X comps: add water tracer fields for Flrr_flood
billsacks 739030a
X comps: add water tracer fields for some runoff fields
billsacks 8a1e7c6
X comps: add tracer fields for Flrr_volr and Flrr_volrmch
billsacks f1e51c1
X comps: add water tracer fields for Flgl_qice and Flgl_qice_elev
billsacks 6e5ca91
XGLC: Improve logic for ice_covered and topo
billsacks 1199901
XGLC: Export Sg_area
billsacks a0238ee
Change dimension order convention for rank-3 tracer fields
billsacks 002beed
X comps: change some lnd and glc values to better test lnd->glc mapping
billsacks d11c256
Merge remote-tracking branch 'origin/main' into water_tracers
billsacks b95d74c
Add a comment
billsacks 3da6da8
Extract subroutine to remove duplication in med_io_write_FB
billsacks e07c439
Extract subroutine to remove duplication in med_io_read_FB
billsacks 419e27f
Use shr_wtracers_get_bulk_fieldname instead of shr_string_withoutSuffix
billsacks efc9898
Correct documentation
billsacks 49c35eb
Merge remote-tracking branch 'origin/main' into water_tracers
billsacks 00e41c5
Restore Figg_rofi in fd_cesm.yaml
billsacks File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 2 additions & 0 deletions
2
cime_config/testdefs/testmods_dirs/drv/glc_avg_frequently/README
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| This testmod turns on more frequent averaging of the fields sent to glc so that the | ||
| mapping of these fields can be tested in a run shorter than a year. |
1 change: 1 addition & 0 deletions
1
cime_config/testdefs/testmods_dirs/drv/glc_avg_frequently/shell_commands
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| ./xmlchange GLC_AVG_PERIOD=glc_coupling_period |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm putting the new variables in ALLCOMP_attributes. I'm not sure if this is right, or if these should go in DRIVER_attributes. I chose ALLCOMP_attributes just because there was more stuff (and more relevant stuff) there, but I'm not sure why I'd choose one over the other.
But actually, maybe ALLCOMP_attributes is needed given that MOM may need to access these rather than going through the share code??
@mvertens do you have guidance here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@billsacks - if any component needs this variable - then it should belong in ALLCOMP_attributes. I think I envisioned the DRIVER_attributes as having variables that are available on all processors but are specific to the driver itself (e.g. pio, etc).
I am not sure why the following variables
are in the DRIVER_attributes and not in the ALLCOMP_attributes.
@jedwards4b - what are your thoughts on this?