Skip to content

Complete CCPPization of CAM7 hb_free_atm (for CAM-SIMA) - #414

Open
jimmielin wants to merge 4 commits into
ESCOMP:mainfrom
jimmielin:hplin/hb_free_atm
Open

jimmielin wants to merge 4 commits into
ESCOMP:mainfrom
jimmielin:hplin/hb_free_atm

Conversation

@jimmielin

Copy link
Copy Markdown
Collaborator

Tag name (The PR title should also include the tag name):
Originator(s): @jimmielin

Description (include issue title and the keyword ['closes', 'fixes', 'resolves'] and issue number):

  • Complete CCPPization of CAM7 hb_free_atm for use above CLUBB

List all namelist files that were added or changed:

List all files eliminated and why:

List all files added and what they do:

A       test/test_suites/suite_vdiff_holtslag_boville_free_atm.xml
  - new SDF

List all existing files that have been modified, and describe the changes:
(Helpful git command: git diff --name-status main...<your_branch_name>)

M       schemes/vertical_diffusion/diffusion_stubs.F90
  - new Beljaars-only interstitial to facilitate reading from snapshot

List all automated tests that failed, as well as an explanation for why they weren't fixed:

Is this an answer-changing PR? If so, is it a new physics package, algorithm change, tuning change, etc?

New physics. Will be acc by CAM-SIMA PR to add regression test
Code is already in CAM from previous HB refactor and b4b

If yes to the above question, describe how this code was validated with the new/modified features:

@nusbaume
nusbaume requested a review from cacraigucar July 15, 2026 16:17

@cacraigucar cacraigucar left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Someone with more knowledge of CAM7 structure will need to review the SDF for its contents of what is being called and the order. I didn't see any problems in the Fortran code or the contents of the SDF.

@jimmielin
jimmielin requested a review from nusbaume July 21, 2026 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants