Skip to content

Add SonarCloud snapshot and generated Sonar findings for PR #3540 #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Easton97-Jens wants to merge 5 commits into
base: v3/master-json2
Choose a base branch
from
Open

Add SonarCloud snapshot and generated Sonar findings for PR #3540 #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
57bf6d2
Restore rules_set include required by XML processor build
Easton97-Jens Apr 14, 2026
7c4f24a
Merge pull request #74 from Easton97-Jens/codex/systematische-behebun…
Easton97-Jens Apr 14, 2026
8197d2b
Refactor open critical Sonar complexity and nesting findings
Easton97-Jens Apr 14, 2026
9c29515
Merge pull request #77 from Easton97-Jens/codex/bearbeite-critical-so…
Easton97-Jens Apr 14, 2026
d679820
Add PR 3540 Sonar snapshot and generated finding tables
Easton97-Jens Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
222 changes: 222 additions & 0 deletions analysis/pr3540_all_findings_table.md
View file
Open in desktop

Large diffs are not rendered by default.

1,247 changes: 1,247 additions & 0 deletions analysis/pr3540_commits.json
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions analysis/pr3540_hotspots.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
{"paging":{"pageIndex":1,"pageSize":500,"total":0},"hotspots":[],"components":[]}
1 change: 1 addition & 0 deletions analysis/pr3540_issues_closed.json
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions analysis/pr3540_issues_open.json
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions analysis/pr3540_measures.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
{"component":{"id":"AZ19zODIui8tjlZZYgU6","key":"owasp-modsecurity_ModSecurity","name":"ModSecurity","qualifier":"TRK","measures":[{"metric":"reliability_rating","value":"1.0","bestValue":true},{"metric":"code_smells","value":"34","bestValue":false},{"metric":"duplicated_lines_density","value":"2.1","bestValue":false},{"metric":"new_vulnerabilities","periods":[{"index":1,"value":"0","bestValue":true}]},{"metric":"security_rating","value":"1.0","bestValue":true},{"metric":"new_reliability_rating","periods":[{"index":1,"value":"1.0","bestValue":true}]},{"metric":"new_security_rating","periods":[{"index":1,"value":"1.0","bestValue":true}]},{"metric":"security_hotspots","value":"0","bestValue":true},{"metric":"new_bugs","periods":[{"index":1,"value":"0","bestValue":true}]},{"metric":"new_code_smells","periods":[{"index":1,"value":"34","bestValue":false}]},{"metric":"sqale_rating","value":"1.0","bestValue":true},{"metric":"alert_status","value":"OK"},{"metric":"bugs","value":"0","bestValue":true},{"metric":"new_security_hotspots","periods":[{"index":1,"value":"0","bestValue":true}]},{"metric":"ncloc","value":"12225"},{"metric":"vulnerabilities","value":"0","bestValue":true},{"metric":"new_maintainability_rating","periods":[{"index":1,"value":"1.0","bestValue":true}]},{"metric":"new_security_hotspots_reviewed","periods":[{"index":1,"value":"100.0","bestValue":true}]},{"metric":"new_duplicated_lines_density","periods":[{"index":1,"value":"0.0","bestValue":true}]}],"pullRequest":"3540"}}
36 changes: 36 additions & 0 deletions analysis/pr3540_open_findings_table.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
| ID | Kategorie | Regelcode | Severity | Datei | Zeile | Kurzbeschreibung | Konkreter technischer Fix | Risiko der Änderung |
|---|---|---|---|---|---:|---|---|---|
| AZ2NbA47JpYMQiJwV1lh | Issue | cpp:S1066 | MAJOR | src/request_body_processor/xml.cc | 331 | Merge this "if" statement with the enclosing one. | Code an Regel anpassen (sonarspezifisch, je Fundstelle). | Niedrig bis Mittel (abhängig von Logikänderung). |
| AZ2H7l4Bym_e-6l8FQml | Issue | cpp:S6009 | MINOR | src/request_body_processor/json.cc | 42 | Replace this const reference to "std::string" by a "std::string_view". | Code an Regel anpassen (sonarspezifisch, je Fundstelle). | Niedrig bis Mittel (abhängig von Logikänderung). |
| AZ2H7l3vym_e-6l8FQmj | Issue | cpp:S6024 | MINOR | src/request_body_processor/json_adapter.cc | 56 | Prefer free functions over member functions when handling objects of generic type "InputType". | Code an Regel anpassen (sonarspezifisch, je Fundstelle). | Niedrig bis Mittel (abhängig von Logikänderung). |
| AZ2H7l3vym_e-6l8FQmk | Issue | cpp:S995 | MINOR | src/request_body_processor/json_adapter.cc | 57 | Make the type of this parameter a pointer-to-const. The current type of "sink" is "class modsecurity::RequestBodyProcessor::JsonEventSink *". | Code an Regel anpassen (sonarspezifisch, je Fundstelle). | Niedrig bis Mittel (abhängig von Logikänderung). |
| AZ2H7l3jym_e-6l8FQmi | Issue | cpp:S6004 | MINOR | src/request_body_processor/json_backend_jsoncons.cc | 623 | Use the init-statement to declare "sync_detail" inside the if statement. | Code an Regel anpassen (sonarspezifisch, je Fundstelle). | Niedrig bis Mittel (abhängig von Logikänderung). |
| AZ2HqeBsWym3B0O6okyS | Issue | cpp:S5952 | MINOR | test/benchmark/json_benchmark.cc | 71 | Add a using-declaration to this derived class to inherit the constructors of "runtime_error", and remove the ones you manually duplicated. Note that this may add other constructors to your derived class. | Code an Regel anpassen (sonarspezifisch, je Fundstelle). | Niedrig bis Mittel (abhängig von Logikänderung). |
| AZ2HqeBsWym3B0O6okyT | Issue | cpp:S6004 | MINOR | test/benchmark/json_benchmark.cc | 144 | Use the init-statement to declare "current" inside the if statement. | Code an Regel anpassen (sonarspezifisch, je Fundstelle). | Niedrig bis Mittel (abhängig von Logikänderung). |
| AZ2DWE24t-zbsGOGdN_K | Issue | cpp:S4998 | MAJOR | test/benchmark/json_benchmark.cc | 316 | Replace this use of "unique_ptr" by a raw pointer or a reference (possibly const). | Code an Regel anpassen (sonarspezifisch, je Fundstelle). | Niedrig bis Mittel (abhängig von Logikänderung). |
| AZ2DVDgODPiZK5yPV1-J | Issue | cpp:S1188 | MAJOR | test/regression/regression_test.cc | 235 | This lambda has 23 lines, which is greater than the 20 lines authorized. Split it into several lambdas or functions, or make it a named function. | Code an Regel anpassen (sonarspezifisch, je Fundstelle). | Niedrig bis Mittel (abhängig von Logikänderung). |
| AZ2CBI6Kkud7vHWq0tqj | Issue | cpp:S6022 | MAJOR | src/operators/validate_byte_range.cc | 157 | Use "std::byte" for byte-oriented data manipulation. | Code an Regel anpassen (sonarspezifisch, je Fundstelle). | Niedrig bis Mittel (abhängig von Logikänderung). |
| AZ2CA_xuGCkM6OziEPeu | Issue | cpp:S4144 | MAJOR | test/unit/json_backend_depth_tests.cc | 50 | Update this method so that its implementation is not identical to on_key. | Code an Regel anpassen (sonarspezifisch, je Fundstelle). | Niedrig bis Mittel (abhängig von Logikänderung). |
| AZ1-doCWXISY38E6TxpK | Issue | cpp:S6009 | MINOR | test/benchmark/json_benchmark.cc | 321 | Replace this const reference to "std::string" by a "std::string_view". | Code an Regel anpassen (sonarspezifisch, je Fundstelle). | Niedrig bis Mittel (abhängig von Logikänderung). |
| AZ1-doCWXISY38E6TxpR | Issue | cpp:S6009 | MINOR | test/benchmark/json_benchmark.cc | 419 | Replace this const reference to "std::string" by a "std::string_view". | Code an Regel anpassen (sonarspezifisch, je Fundstelle). | Niedrig bis Mittel (abhängig von Logikänderung). |
| AZ1-doCWXISY38E6TxpU | Issue | cpp:S6009 | MINOR | test/benchmark/json_benchmark.cc | 486 | Replace this const reference to "std::string" by a "std::string_view". | Code an Regel anpassen (sonarspezifisch, je Fundstelle). | Niedrig bis Mittel (abhängig von Logikänderung). |
| AZ190QEMSTzC4JOHOn9q | Issue | cpp:S6022 | MAJOR | src/operators/validate_byte_range.cc | 73 | Use "std::byte" for byte-oriented data manipulation. | Code an Regel anpassen (sonarspezifisch, je Fundstelle). | Niedrig bis Mittel (abhängig von Logikänderung). |
| AZ190QFsSTzC4JOHOn9u | Issue | cpp:S3562 | MAJOR | src/request_body_processor/json_backend_jsoncons.cc | 220 | 4 enumeration values not handled in switch: 'int64_value', 'uint64_value', 'half_value'... | Code an Regel anpassen (sonarspezifisch, je Fundstelle). | Niedrig bis Mittel (abhängig von Logikänderung). |
| AZ190QA8STzC4JOHOn9k | Issue | cpp:S5945 | MAJOR | src/utils/json_writer.cc | 156 | Use "std::string" instead of a C-style char array. | Code an Regel anpassen (sonarspezifisch, je Fundstelle). | Niedrig bis Mittel (abhängig von Logikänderung). |
| AZ190QA8STzC4JOHOn9n | Issue | cpp:S6022 | MAJOR | src/utils/json_writer.cc | 184 | Use "std::byte" for byte-oriented data manipulation. | Code an Regel anpassen (sonarspezifisch, je Fundstelle). | Niedrig bis Mittel (abhängig von Logikänderung). |
| AZ190QA8STzC4JOHOn9o | Issue | cpp:S6022 | MAJOR | src/utils/json_writer.cc | 185 | Use "std::byte" for byte-oriented data manipulation. | Code an Regel anpassen (sonarspezifisch, je Fundstelle). | Niedrig bis Mittel (abhängig von Logikänderung). |
| AZ190QIVSTzC4JOHOn-g | Issue | cpp:S2807 | MAJOR | test/common/json.h | 78 | Make this member overloaded operator a hidden friend. | Code an Regel anpassen (sonarspezifisch, je Fundstelle). | Niedrig bis Mittel (abhängig von Logikänderung). |
| AZ190QIVSTzC4JOHOn-h | Issue | cpp:S2807 | MAJOR | test/common/json.h | 123 | Make this member overloaded operator a hidden friend. | Code an Regel anpassen (sonarspezifisch, je Fundstelle). | Niedrig bis Mittel (abhängig von Logikänderung). |
| AZ190QIVSTzC4JOHOn-i | Issue | cpp:S1181 | MAJOR | test/common/json.h | 219 | Catch a more specific exception instead of a generic one. | Code an Regel anpassen (sonarspezifisch, je Fundstelle). | Niedrig bis Mittel (abhängig von Logikänderung). |
| AZ190QIVSTzC4JOHOn-j | Issue | cpp:S995 | MINOR | test/common/json.h | 232 | Make the type of this parameter a pointer-to-const. The current type of "error" is "std::string *". | Code an Regel anpassen (sonarspezifisch, je Fundstelle). | Niedrig bis Mittel (abhängig von Logikänderung). |
| AZ190QIVSTzC4JOHOn-k | Issue | cpp:S995 | MINOR | test/common/json.h | 242 | Make the type of this parameter a pointer-to-const. The current type of "error" is "std::string *". | Code an Regel anpassen (sonarspezifisch, je Fundstelle). | Niedrig bis Mittel (abhängig von Logikänderung). |
| AZ190QIVSTzC4JOHOn-l | Issue | cpp:S995 | MINOR | test/common/json.h | 252 | Make the type of this parameter a pointer-to-const. The current type of "error" is "std::string *". | Code an Regel anpassen (sonarspezifisch, je Fundstelle). | Niedrig bis Mittel (abhängig von Logikänderung). |
| AZ190QIVSTzC4JOHOn-m | Issue | cpp:S995 | MINOR | test/common/json.h | 262 | Make the type of this parameter a pointer-to-const. The current type of "error" is "std::string *". | Code an Regel anpassen (sonarspezifisch, je Fundstelle). | Niedrig bis Mittel (abhängig von Logikänderung). |
| AZ190QIVSTzC4JOHOn-n | Issue | cpp:S995 | MINOR | test/common/json.h | 269 | Make the type of this parameter a pointer-to-const. The current type of "error" is "std::string *". | Code an Regel anpassen (sonarspezifisch, je Fundstelle). | Niedrig bis Mittel (abhängig von Logikänderung). |
| AZ190QIVSTzC4JOHOn-o | Issue | cpp:S995 | MINOR | test/common/json.h | 279 | Make the type of this parameter a pointer-to-const. The current type of "error" is "std::string *". | Code an Regel anpassen (sonarspezifisch, je Fundstelle). | Niedrig bis Mittel (abhängig von Logikänderung). |
| AZ190QIVSTzC4JOHOn-p | Issue | cpp:S1181 | MAJOR | test/common/json.h | 309 | Catch a more specific exception instead of a generic one. | Code an Regel anpassen (sonarspezifisch, je Fundstelle). | Niedrig bis Mittel (abhängig von Logikänderung). |
| AZ190QIVSTzC4JOHOn-q | Issue | cpp:S1181 | MAJOR | test/common/json.h | 321 | Catch a more specific exception instead of a generic one. | Code an Regel anpassen (sonarspezifisch, je Fundstelle). | Niedrig bis Mittel (abhängig von Logikänderung). |
| AZ190QIVSTzC4JOHOn-r | Issue | cpp:S1181 | MAJOR | test/common/json.h | 333 | Catch a more specific exception instead of a generic one. | Code an Regel anpassen (sonarspezifisch, je Fundstelle). | Niedrig bis Mittel (abhängig von Logikänderung). |
| AZ190QKvSTzC4JOHOn-4 | Issue | cpp:S5817 | MAJOR | test/regression/regression_test.cc | 431 | This function should be declared "const". | Code an Regel anpassen (sonarspezifisch, je Fundstelle). | Niedrig bis Mittel (abhängig von Logikänderung). |
| AZ190QIESTzC4JOHOn-d | Issue | cpp:S886 | MINOR | src/modsecurity.cc | 232 | Refactor this loop so that it is less error-prone. | Code an Regel anpassen (sonarspezifisch, je Fundstelle). | Niedrig bis Mittel (abhängig von Logikänderung). |
| AZ190QIESTzC4JOHOn-e | Issue | cpp:S886 | MINOR | src/modsecurity.cc | 288 | Refactor this loop so that it is less error-prone. | Code an Regel anpassen (sonarspezifisch, je Fundstelle). | Niedrig bis Mittel (abhängig von Logikänderung). |
Loading