Add NowNodes blockbook server to eCash for sync/send recovery#453
Open
j0ntz wants to merge 1 commit into
Open
Conversation
eCash's only blockbook sync server (blockbook.fabien.cash) is down, so wallets cannot resync or send. Add the NowNodes blockbook websocket server with the nowNodesApiKey template to defaultSettings.blockbookServers, matching the pattern already used by Bitcoin Cash, Bitcoin and Dogecoin. The GUI already passes ECASH_INIT.nowNodesApiKey to the ecash plugin. Claude-Session: https://claude.ai/code/session_01NWSBgjqm8PkwCp8ziCrgX1
Contributor
Author
📸 Test evidence — XEC resync via new NowNodes serveragent proof 1213046875952149 01 xec wallets funded agent proof 1213046875952149 02 xec wallet balance agent proof 1213046875952149 03 resync confirm agent proof 1213046875952149 04 resync complete synced Captured by the agent's in-app test run (build-and-test). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
none
Description
eCash (XEC) wallets could not resync or send: the plugin's only blockbook sync server,
wss://blockbook.fabien.cash/websocket, is down, so resync hangs and sends fail. This is an active support issue and a regression.The NowNodes XEC blockbook host was already referenced in
engineInfo.serverConfigs, but only as an HTTP broadcast fallback — it was never indefaultSettings.blockbookServers, so it was never used for the websocket sync. This adds it, with the%{nowNodesApiKey}template thatSocket.tssubstitutes from the plugin's init options, matching the pattern Bitcoin Cash, Bitcoin and Dogecoin already use.The consuming app already wires
ECASH_INIT.nowNodesApiKeythrough to theecashplugin (edge-react-guicorePlugins.ts), using the same NowNodes key as the other UTXO coins; production env just needs that key populated for eCash (a deploy-config change, like every other NowNodes-backed coin).Verification
blockbook.fabien.cashno longer serves the blockbook API;xec-blockbook.nownodes.ioreturns401without an API key and200with the key, reporting a live, in-sync eCash node ("coin":"ECash","network":"XEC","inSync":true).ECASH_INIT.nowNodesApiKeyset): resynced a funded XEC wallet ("My eCash", 126,536.16 XEC). Resync completed and the wallet stayed synced with a live balance — data that can only come from the NowNodes server, since the old server is down. Screenshots attached.Asana: https://app.asana.com/0/1215088146871429/1213046875952149
Note
Low Risk
Config-only addition of a fallback sync server using an established NowNodes URL pattern; no changes to spending, key handling, or sync logic beyond server list selection.
Overview
Adds a second default blockbook websocket for eCash so wallets can fall back when
wss://blockbook.fabien.cash/websocketis down.defaultSettings.blockbookServersinecash.tsnow includeswss://xec-blockbook.nownodes.io/wss/%{nowNodesApiKey}alongside the existing Fabien server. That mirrors Bitcoin, Bitcoin Cash, and Dogecoin and wires the same NowNodes host that was already listed inengineInfo.serverConfigsfor HTTP broadcast into websocket sync. The%{nowNodesApiKey}placeholder is filled from plugin init options at connection time.CHANGELOG records the fix under Unreleased.
Reviewed by Cursor Bugbot for commit 3da1d2f. Bugbot is set up for automated code reviews on this repo. Configure here.