Post release v26.04#9051
Merged
rustyrussell merged 18 commits intoElementsProject:masterfrom Apr 30, 2026
Merged
Conversation
rustyrussell
force-pushed
the
guilt/post-release-v26.04
branch
from
0b7d809 to
5f77dc8
Compare
rustyrussell
force-pushed
the
guilt/post-release-v26.04
branch
2 times, most recently
from
c68f233 to
1f30913
Compare
rustyrussell
force-pushed
the
guilt/post-release-v26.04
branch
from
1f30913 to
fa58665
Compare
Document how to update to the latest bolts, and how to remove deprecated features. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
… it. We actually changed this by default last release, and nobody noticed! Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Regenerate the CSV files from the specs, apply the wire/extracted*.patch files and make sure they are up-to-date. This catches people editing the files: if you want to change them, you have to create a new patch file. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
The current BOLTVERSION doesn't match our implementation, so when we `make extract-bolt-csv` we get a change. Fold the changes into a single splice patch. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
I accidentally dropped this! Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
We already required it, so the changes are textual. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
We add it to our code, even though we don't use it (yet?). Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
guilt/post-release-v26.04
branch
from
fa58665 to
0ca6c2c
Compare
Touches a pile of tests, but they're easy to find. Changelog-Changed: Protocol: We now wait 72 blocks, not 12, before closing channels (BOLT update) Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Attributable errors and some reordering, but nothing beyond text changes for us.
This means we can assume support, but we *can't* assume it's present, because of keysend, which doesn't use it. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
There's a new BOLT 12 test, which checks that the ->currencies array isn't empty. We were treating it as missing, which is wrong. So allocate empty arrays when they appear, instead of setting them to NULL. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
It's a bit moot, since we can't pay them anyway, but this brings us into line with the test vectors. It *did* catch that we treated empty as missing, though. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This needs Dusty's examination... Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
There's a new test for bolt12 in commit 7153bed9705d7493 ("BOLT 12:
add test vector for invalid bech32 padding (ElementsProject#1312)") which requires us
to b stricter in decoding.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
And enhance some of our quotes to use `...` at the start to link them. As they were, we didn't notice when a new requirement appeared in the middle. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
guilt/post-release-v26.04
branch
from
0ca6c2c to
a04c1a2
Compare
rustyrussell
merged commit 0c63d01
into
ElementsProject:master
125 of 130 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #9044Merged!All the post-release catchups, and some (textual) fixes which slipped through CI.
There's one more set of BOLT changes: the splice merge. But our code has deviated from that, so I will work on that separately with @ddustin